Repository navigation
Conversation
Every model editor registered a workspace listener for its project's translation files and never removed it, so closed editors stayed in memory and later refreshes ran against a disposed tree. Its icon registry was never disposed either. The editor now removes the listener and disposes the registry when it is closed. Assisted-by: multiple AI agents and layers of automated tooling 🤖
vogella
force-pushed
the
vogella/e4-model-editor-leaks
branch
from
October 10, 2026 10:13
99dd7d8 to
af4147e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each e4 model editor registered a workspace resource listener for its project's translation files and never removed it, so every closed editor stayed reachable from the workspace and a later change to a properties file or the manifest refreshed a disposed tree. The editor's icon registry was never disposed either, so its icons lived until the display was disposed. The editor now removes the listener and disposes the registry on close, and a new test checks that a disposed translation provider stops reacting to properties file changes.