Repository navigation
Conversation
The URI dialog created its two toolbar images on every open and the project folder page created a new image for every tree item it labelled, and none of them was disposed; both now go through a resource manager owned by the toolbar or the label provider. BundleImageCache kept its placeholder image in a static field, so disposing one cache disposed the placeholder still shown by every other one; each cache now owns its own. ContributionDataFile gets equals and hashCode, so the icon search dialog's image cache finds the images it already loaded instead of loading them again on every repaint. Assisted-by: multiple AI agents and layers of automated tooling 🤖
vogella
force-pushed
the
vogella/e4-leaks-dialog-images
branch
from
October 10, 2026 10:13
13aebaa to
6a0eda7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URI dialog created its toolbar images on every open, and the project folder page created a new image for every tree item it labelled; neither was ever disposed, and both now go through a resource manager that owns them. BundleImageCache kept its placeholder image in a static field, so disposing one cache broke the placeholder every other open cache was still showing; each cache now has its own. ContributionDataFile gets equals and hashCode, so the icon search dialog's image cache stops reloading icons on every repaint.