Repository navigation
Conversation
Hiding the list tab disposed only the tab item, so its composite, its images and the drop-down menu of its toolbar stayed alive until the editor or the workbench window closed. The tab also registered itself as the active object viewer in the application context when it was created, which kept a closed editor reachable. The tab now disposes all of that in its @PreDestroy, its context is disposed, and the viewer is registered only while the list tab is selected, including when the editor selects it programmatically. Cell editing in the list tab also created a new cell editor widget on every activation; each column now reuses its editors. Assisted-by: multiple AI agents and layers of automated tooling 🤖
vogella
force-pushed
the
vogella/e4-leaks-list-tab
branch
from
October 10, 2026 10:14
26ff5c4 to
756c338
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hiding the list tab of the e4 model editor disposed only the tab item, so its composite, images and toolbar drop-down menu stayed alive until the editor or workbench window closed. The tab also registered itself as the active object viewer as soon as it was created, which kept closed editors reachable. The tab now cleans all of this up when it is hidden, and it is registered only while it is actually selected. Cell editing in the list also stops creating a new cell editor widget on every activation.