Repository navigation
Conversation
PartStackEditor bound a new detail observable as viewer input on every selection and StringModelFragment on every keystroke in the extended element field, and none of them was disposed; both now set the input once when the form is created. VirtualEntry kept its listener on the model element after the tree disposed the entry's list, so it now disposes its source observable with the list. The IExtensionLookup and IBundleProjectService references are released after use, and cutting with an empty selection no longer leaves a clipboard undisposed. Assisted-by: multiple AI agents and layers of automated tooling 🤖
vogella
force-pushed
the
vogella/e4-leaks-observables
branch
from
October 10, 2026 10:13
3e96c83 to
04559f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PartStackEditor and StringModelFragment created a new detail observable on every selection or keystroke and never disposed it; they now set their viewer input once when the form is created. VirtualEntry kept listening to the model element after the tree had disposed the entry, and it now disposes its source observable along with its list. The IExtensionLookup and IBundleProjectService references are released after use, and cutting with an empty selection no longer leaves a clipboard undisposed.