Update for release 4.35

[github-actions]

A new release milstone was created, please review the changes and merge if appropriate.

[github-actions]

Test Results

80 files   -    403  80 suites   - 403   3s ⏱️ - 12m 31s
34 tests  -  4 061  34 ✅  -  4 051  0 💤  -  7  0 ❌  - 3 
34 runs   - 16 139  34 ✅  - 16 046  0 💤  - 90  0 ❌  - 3 

Results for commit 73a3edd. ± Comparison against base commit e6588c2.

This pull request removes 4061 tests.

org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
org.eclipse.swt.tests.junit.DPIUtilTests ‑ scaleDownFloat
org.eclipse.swt.tests.junit.DPIUtilTests ‑ scaleDownFloatArray
org.eclipse.swt.tests.junit.DPIUtilTests ‑ scaleDownInteger
org.eclipse.swt.tests.junit.DPIUtilTests ‑ scaleDownPoint
org.eclipse.swt.tests.junit.DPIUtilTests ‑ scaleDownRectangle
org.eclipse.swt.tests.junit.DPIUtilTests ‑ scaleUpFloat
org.eclipse.swt.tests.junit.DPIUtilTests ‑ scaleUpIntArray
org.eclipse.swt.tests.junit.DPIUtilTests ‑ scaleUpInteger
org.eclipse.swt.tests.junit.DPIUtilTests ‑ scaleUpPoint
…

♻️ This comment has been updated with latest results.

[akurtakov]

#1615 deserves a minor version bump and the prospects to land it in are good so I'll change the version bump to be a minor one.

[akurtakov]

Now it fails with:

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.10:verify (verify) on project org.eclipse.swt.gtk.linux.ppc64le: There are API errors:
18:01:42  [ERROR] META-INF/MANIFEST.MF:1 The minor version should be the same for version 3.129.0, since no new APIs have been added since version 3.128.0
18:01:42  [ERROR] -> [Help 1]
18:01:42  org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.10:verify (verify) on project org.eclipse.swt.gtk.linux.ppc64le: There are API errors:
18:01:42  META-INF/MANIFEST.MF:1 The minor version should be the same for version 3.129.0, since no new APIs have been added since version 3.128.0

[akurtakov]

I believe we should stop runnint apitools for swt.

[akurtakov]

What should we do here ?

[merks]

Suppress the error...

We really do need to know in the future if some change breaks API. I can't reproduce that error such that I could quick fix it to create the suppression of it. 😞

Which version of API tools are being used?

@HannesWell How best to make progress here?

[HannesWell]

Suppress the error...

Agree.

We really do need to know in the future if some change breaks API. I can't reproduce that error such that I could quick fix it to create the suppression of it. 😞

You can change the environment in the target for the workspace TP and the API baseline explicitly to linux.gtk.riscv64 for example.
And then I get one on Windows for the checked-out linux.gtk.riscv64 fragment the corresponding error:

which can be suppressed with

    <resource path="META-INF/MANIFEST.MF">
        <filter id="926941240">
            <message_arguments>
                <message_argument value="3.129.0"/>
                <message_argument value="3.128.0"/>
            </message_arguments>
        </filter>
    </resource>

[akurtakov]

So "only" failing tests. I'm pushing this one. Thanks @HannesWell !