Skip to content

Edge: Tests: Add test-case for evaluate opening new window #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2175,6 +2175,30 @@ public void test_evaluate_array_mixedTypes () {
assertTrue(message, passed);
}

/**
* https://github.com/eclipse-platform/eclipse.platform.swt/issues/1771
* https://github.com/eclipse-platform/eclipse.platform.swt/pull/1973
*/
@Test
public void test_evaluate_OpeningNewWindow() throws Exception {
AtomicBoolean initialLoad = new AtomicBoolean();
AtomicBoolean openWindowListenerCalled = new AtomicBoolean();
browser.addProgressListener(ProgressListener.completedAdapter(e -> initialLoad.set(true)));
browser.addOpenWindowListener(event -> {
event.required = true; // block default
openWindowListenerCalled.set(true);
});
browser.setText("""
<button id="button" onClick="window.open('https://eclipse.org');">open eclipse.org</button>
""");
waitForPassCondition(initialLoad::get);

browser.evaluate("""
document.getElementById("button").click();
""");

waitForPassCondition(openWindowListenerCalled::get);
}

ProgressListener callCustomFunctionUponLoad = completedAdapter(event -> browser.execute("callCustomFunction()"));

Expand Down
Loading