Skip to content

Support cascaded java callbacks in Edge #1919 #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fedejeanne
Copy link
Contributor

Add a test to it.

Fixes #1919

Copy link
Contributor

@amartya4256 amartya4256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

Copy link
Contributor

github-actions bot commented Apr 15, 2025

Test Results

   545 files  + 6     545 suites  +6   32m 40s ⏱️ + 3m 59s
 4 373 tests +39   4 361 ✅ +37   12 💤 +3  0 ❌  - 1 
16 634 runs  +42  16 527 ✅ +39  107 💤 +4  0 ❌  - 1 

Results for commit f685edc. ± Comparison against base commit f734dc6.

♻️ This comment has been updated with latest results.

@amartya4256
Copy link
Contributor

However, the test fails for Linux.

Add a test to it. The test is currently deactivated for Linux (see
eclipse-platform#2021)

Fixes eclipse-platform#1919
@fedejeanne fedejeanne force-pushed the cascaded_java_callback_edge branch from bc8dd64 to f685edc Compare April 15, 2025 11:12
@fedejeanne
Copy link
Contributor Author

However, the test fails for Linux.

I noticed, let's put a pin on it: #2021

@fedejeanne fedejeanne linked an issue Apr 15, 2025 that may be closed by this pull request
@fedejeanne fedejeanne marked this pull request as ready for review April 15, 2025 11:28
@fedejeanne fedejeanne merged commit 70fab96 into eclipse-platform:master Apr 15, 2025
10 checks passed
@fedejeanne fedejeanne deleted the cascaded_java_callback_edge branch April 15, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge: freezes in evalute() Edge: Operation timed out on evaluate()
2 participants