Skip to content

[Edge] Add link to Edge FAQ with information on installing runtime #2000 #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HeikoKlare
Copy link
Contributor

When the OS lacks a WebView2 runtime installation, an error is shown once a browser is initialized since Edge is used as the default browser on Windows. This change adds a link to the according FAQ page with information on how to install such a runtime to the error message.

Resolves #2000

…lipse-platform#2000

When the OS lacks a WebView2 runtime installation, an error is shown
once a browser is initialized since Edge is used as the default browser
on Windows. This change adds a link to the according FAQ page with
information on how to install such a runtime to the error message.

Resolves
eclipse-platform#2000
Copy link
Contributor

Test Results

   545 files  + 6     545 suites  +6   30m 24s ⏱️ -14s
 4 373 tests +37   4 361 ✅ +35   12 💤 +3  0 ❌  - 1 
16 634 runs  +37  16 520 ✅ +35  114 💤 +3  0 ❌  - 1 

Results for commit f99dc95. ± Comparison against base commit 2a00032.

@sratz
Copy link
Member

sratz commented Apr 22, 2025

Is GitHub raw file access supposed to be the "official" location of the FAQ now?

Or should this be published to https://eclipse.dev/eclipse/swt/faq.html somehow?

@vogella
Copy link
Contributor

vogella commented Apr 22, 2025

Is GitHub raw file access supposed to be the "official" location of the FAQ now?

Yes. Most of the FAQs were part of the wiki and the wiki entries have been migrated to Markdown. I would suggest to move the relevant entries of the https://eclipse.dev/eclipse/swt/faq.html also to the FAQ md.

Or should this be published to https://eclipse.dev/eclipse/swt/faq.html somehow?

@HeikoKlare
Copy link
Contributor Author

May be we could forward https://eclipse.dev/eclipse/swt/faq.html to the GitHub raw file to at least keep the existing link point to the most up-to-date FAQ?

@sratz
Copy link
Member

sratz commented Apr 22, 2025

May be we could forward https://eclipse.dev/eclipse/swt/faq.html to the GitHub raw file to at least keep the existing link point to the most up-to-date FAQ?

Hmm, there are many more SWT-specific FAQ entries in that list than we have under

https://github.com/eclipse-platform/eclipse.platform/tree/master/docs/FAQ/

So we'd lose a lot of information.

I think we would need to migrate all SWT FAQ entries that are still relevant there to markdown.

@HeikoKlare
Copy link
Contributor Author

Hmm, there are many more SWT-specific FAQ entries in that list than we have under

https://github.com/eclipse-platform/eclipse.platform/tree/master/docs/FAQ/

So we'd lose a lot of information.

I think we would need to migrate all SWT FAQ entries that are still relevant there to markdown.

Yeah, right. I actually meant to add a redirect once everything has been migrated. But to be honest, I was not aware that there is still so much information to be migrated (I thought that most of it was already done).

@vogella
Copy link
Contributor

vogella commented Apr 24, 2025

I was not aware that there is still so much information to be migrated (I thought that most of it was already done).

IIRC the information on the wikis were migrated (as the wiki was going down), so far not the rest.

@merks
Copy link
Contributor

merks commented Apr 24, 2025

FYI, I'm currently trying to make sense of what's all there (documentation in the form of *.md) in different repositories. I am also experimenting with client-side markdown rendering such that it's possible to embed the *.md content within the website. E.g., here we have a page that uses the query parameter file= to read the markdown file (via api.github.com) and render it locally:

image

I'm also looking to generate a list of a folder's contents (so that we don't have to maintain an index):

image

As a result, I stumbled upon this

https://github.com/eclipse-platform/eclipse.platform/blob/master/docs/FAQ.md

I noticed that the very first link on this page is broken:

https://github.com/eclipse-platform/eclipse.platform/blob/master/docs/FAQ/The_Official_Eclipse_FAQs.md

@vogella Can docs/FAQ.md be deleted given we have docs/FAQ/The_Official_Eclipse_FAQs.md?

In any case, I hope to make it easier to find and navigate this valuable content much of which @vogella helped migrate...

@vogella
Copy link
Contributor

vogella commented Apr 24, 2025

@vogella Can docs/FAQ.md be deleted given we have docs/FAQ/The_Official_Eclipse_FAQs.md?

It is not the same content in https://github.com/eclipse-platform/eclipse.platform/blob/master/docs/FAQ.md

In theory someone would have to go though it, check if the entries are still relevant and move them to the other FAQ.I did some clean-up in this document but ran (way) out of time.

@merks
Copy link
Contributor

merks commented Apr 24, 2025

I see. So we have 3 different FAQ sources, none of which are known to be complete. 😱 Oh well, one step at a time.

@vogella
Copy link
Contributor

vogella commented Apr 25, 2025

First link here seems also outdated it still points to https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Platform&component=SWT and the first entry explains in details what to put into the Bugzilla issue.
Also scrolling throw the SWT FAQ shows tons of outdated entries, like: "What do I need to run the SWT Browser inside Eclipse on Solaris?" or "Why do I get strange drawing behaviour when running 32 bit Eclipse on a 64 bit GTK platform?".

Maybe a first step would be to delete the obvious obsolete entries in the SWT FAQ. (I'm not planning to do this, but I assume that would be a relative quick thing to do for an active SWT developer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[windows] WebView2 runtime not found
4 participants