Add FreeBSD aarch64/x86_64 platforms' build. #2044
Conversation
- part of eclipse-platform/eclipse.platform.releng.aggregator#2959 - add 2 SWT binary modules for FreeBSD: org.eclipse.swt.gtk.freebsd.aarch64 org.eclipse.swt.gtk.freebsd.x86_64 - changes made to the build.sh script and make_linux.mak (renamed to make_unix.mak) to support compiling FreeBSD native binaries for SWT. To support cross-compiling from Linux to FreeBSD, for the same hardware architecture, a Docker container is made available in my fork with detailed instructions: https://github.com/chirontt/eclipse.platform.releng.aggregator/tree/master/cje-production/dockerfiles/alpine/freebsd-cross which will be submitted to the official repo at later stage.
| @@ -44,3 +44,13 @@ requires.9.namespace = org.eclipse.equinox.p2.iu | |||
| requires.9.name = org.eclipse.swt.gtk.linux.riscv64 | |||
| requires.9.range = [$version$,$version$] | |||
| requires.9.filter = (&(osgi.os=linux)(osgi.ws=gtk)(osgi.arch=riscv64)(!(org.eclipse.swt.buildtime=true))) | |||
|
|
|||
There was a problem hiding this comment.
This part can not go in unless actual binaries are produced and pushed .
There was a problem hiding this comment.
Not only this specific file, but without the SWT binaries being officially compiled for FreeBSD and checked in, this whole PR is moot/pointless and shouldn't be merged at all.
And with the SWT being a critical component of Eclipse, failure to merge this PR is also a critical failure for the whole effort in eclipse-platform/eclipse.platform.releng.aggregator#2959
| @@ -38,3 +38,13 @@ requires.8.namespace = org.eclipse.equinox.p2.iu | |||
| requires.8.name = org.eclipse.swt.gtk.linux.riscv64 | |||
| requires.8.range = 0.0.0 | |||
| requires.8.filter = (&(osgi.os=linux)(osgi.ws=gtk)(osgi.arch=riscv64)) | |||
|
|
|||
There was a problem hiding this comment.
This part can not go in unless actual binaries are produced and pushed.
There was a problem hiding this comment.
Ditto, per my reply above
| @@ -34,6 +35,8 @@ | |||
| <modules> | |||
| <module>org.eclipse.swt.cocoa.macosx.x86_64</module> | |||
| <module>org.eclipse.swt.cocoa.macosx.aarch64</module> | |||
| <module>org.eclipse.swt.gtk.freebsd.aarch64</module> | |||
There was a problem hiding this comment.
As these will stay "shell" bundles without actual binaries in them we should not include them so such useless bundles don't get published in the p2 repo. I would be fine if you include them via Maven "freebsd" profile though.
There was a problem hiding this comment.
Ditto, per my reply above
org.eclipse.swt.gtk.freebsd.aarch64andorg.eclipse.swt.gtk.freebsd.x86_64build.shscript and make_linux.mak (renamed tomake_unix.mak) to support compiling FreeBSD native binaries for SWT.To support cross-compiling from Linux to FreeBSD, for the same hardware architecture, a Docker container is made available in my fork with detailed instructions:
https://github.com/chirontt/eclipse.platform.releng.aggregator/tree/master/cje-production/dockerfiles/alpine/freebsd-cross
which will be submitted to the official repo at later stage.