Support disabling the GTK SessionManagerDBus via environment variables #2056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 539 files ±0 539 suites ±0 29m 59s ⏱️ + 1m 34s For more details on these failures, see this check. Results for commit cffb6a2. ± Comparison against base commit 788ba23. ♻️ This comment has been updated with latest results. |
HannesWell
force-pushed
the
session-manager-disable-env-variable
branch
2 times, most recently
from
73d4fbe to
e0e6d15
Compare
For example this simplifies disabling the SessionManagerDBus in CI environments where no bus is available.
akurtakov
force-pushed
the
session-manager-disable-env-variable
branch
from
e0e6d15 to
cffb6a2
Compare
|
Failing Windows test is unrelated. Thanks for this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example this simplifies disabling the
SessionManagerDBusin CI environments where no bus is available.At our CI-server, which formally doesn't have an X-Server installed and uses xvnc I see the following warnings:
Setting the system-property
org.eclipse.swt.internal.SessionManagerDBus.disabledisables theSessionManagerDBusright from the start and prevents these warnings. But I have to set that system-property in the Maven/Tycho pom.xml as well as in all headless eclipse executions we run in our build.It would be more convenient, if I can just set an environment property for the entire pipeline that would be used as proposed here.