[Edge] Improve dialog when WebView2 engine is not available #2035 #2344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good 👍 |
|
@BeckerWdf may I ping you again on this one? If possible, I would like to merge this for M3 to bring it into the upcoming release. |
BeckerWdf
requested changes
Aug 11, 2025
bundles/org.eclipse.swt/Eclipse SWT Browser/common/org/eclipse/swt/browser/Browser.java
Outdated
Show resolved
Hide resolved
Sorry. That got lost. I have some small remark. Besides that it looks fine. |
HeikoKlare
force-pushed
the
issue-2035-followup
branch
from
83f33e0 to
1274fed
Compare
Thank you for the feedback! I adapted the PR accordingly. |
…latform#2035 When a browser is opened and the WebView2 engine used as default is not available, a dialog pops up with additional information and the ability to switch back to the Internet Explorer for the current application session. By now, the dialog lacked the information that the switch to the Internet Explorer is not permanent. In addition, it was not possible to disable that dialog, e.g., for scenarios in which an application is executed in some automation and such a popup blocks automated processes. This change adapts the dialog message to clarify that the switch to Internet Explorer will lose its effect on next application start and refers to the information link which gives more insights on how to permanently switch back to Internet Explorer. In addition, it adds a system property to disable that dialog. Contributes to eclipse-platform#2035
HeikoKlare
force-pushed
the
issue-2035-followup
branch
from
1274fed to
5d6d77b
Compare
BeckerWdf
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a browser is opened and the WebView2 engine used as default is not available, a dialog pops up with additional information and the ability to switch back to the Internet Explorer for the current application session. By now, the dialog lacked the information that the switch to the Internet Explorer is not permanent. In addition, it was not possible to disable that dialog, e.g., for scenarios in which an application is executed in some automation and such a popup blocks automated processes.
This change adapts the dialog message to clarify that the switch to Internet Explorer will lose its effect on next application start and refers to the information link which gives more insights on how to permanently switch back to Internet Explorer. In addition, it adds a system property to disable that dialog.
Contributes to #2035
This is how the dialog now looks like (ignore the large title bars, that's a Windows scaling issue not specific to Eclipse):
@BeckerWdf since you were heavily involved in refining the original dialog, what do you think about the change?
@Bestsoft101 would the changed dialog text have been clearer to you to understand that the effect is temporary and how a permanent switch to IE is done?