Skip to content

[GTK] Do not try to remove fixedHandle if there is none #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2025

Conversation

akurtakov
Copy link
Member

GtkWidgets can act as containers thus SwtFixed don't have to used always.

GtkWidgets can act as containers thus SwtFixed don't have to used
always.
Copy link
Contributor

Test Results

   539 files   -  7     539 suites   - 7   31m 18s ⏱️ + 3m 4s
 4 371 tests  - 54   4 356 ✅  - 52   14 💤  - 3  1 ❌ +1 
16 692 runs   - 54  16 567 ✅  - 52  124 💤  - 3  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 8f70fb6. ± Comparison against base commit e2e8c1d.

This pull request removes 54 tests.
AllWin32Tests ImageWin32Tests ‑ testDisposeDrawnImageBeforeRequestingTargetForOtherZoom
AllWin32Tests ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[1] true
AllWin32Tests ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[2] false
AllWin32Tests ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
AllWin32Tests ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
AllWin32Tests ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[1] true
AllWin32Tests ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[2] false
AllWin32Tests TestTreeColumn ‑ test_ColumnOrder
AllWin32Tests Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
AllWin32Tests Test_org_eclipse_swt_dnd_DND ‑ testFileTransfer
…

@akurtakov
Copy link
Member Author

Windows test failure is unrelated to GTK only change. Merging.

@akurtakov akurtakov merged commit 540a1d7 into eclipse-platform:master Aug 10, 2025
15 of 17 checks passed
@github-project-automation github-project-automation bot moved this to Done in SWT work Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant