Skip to content

Conversation

@deepika-u
Copy link
Contributor

SWT Javadoc bash for 4.38

Fixes #2788

@deepika-u
Copy link
Contributor Author

@HeikoKlare
These are javadoc updates being generated by javadocbasher, can you take a look when you get some time.

But please dont close the task #2788, it is to be merged in RC2 only after verifying it.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

Test Results

104 files   -     7  104 suites   - 7   9s ⏱️ - 17m 32s
 81 tests  - 4 516   81 ✅  - 4 500  0 💤  - 15  0 ❌  - 1 
263 runs   -    19  263 ✅  -    18  0 💤  -  1  0 ❌ ±0 

Results for commit cfda7a6. ± Comparison against base commit 63d5582.

This pull request removes 4516 tests.
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_dollarSign
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_emptyString
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letterA
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16LE_null
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_AsciiLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_Asciiletter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_LotsOfLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letters
…

♻️ This comment has been updated with latest results.

@akurtakov
Copy link
Member

It looks like this PR does the opposite of what should be done. The deleted comment should instead be added in windows/mac javadoc too.

@deepika-u
Copy link
Contributor Author

Thanks for catching that! You’re absolutely right — I misunderstood the requirement and ended up doing the opposite of what was intended.
I’ll update the PR to add the latest changes.

@deepika-u deepika-u force-pushed the 4.38_javadoc_basher_changes branch from d942b1d to 8314654 Compare November 18, 2025 13:03
@deepika-u deepika-u force-pushed the 4.38_javadoc_basher_changes branch from 8314654 to cfda7a6 Compare November 18, 2025 13:07
@deepika-u
Copy link
Contributor Author

I’ve updated the PR as per your suggestion - the changes are added now in Windows and Mac. Please review and let me know if everything looks good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SWT Javadoc bash for 4.38

2 participants