Repository navigation
Conversation
Contributor
Accessibility clients such as VoiceOver request ranges and indexes past the end of the text, which made the string, selected text and line queries throw StringIndexOutOfBoundsException and the attributed string query loop forever. Clamp them to the text and replace the placeholder Cocoa test with a regression test. Fixes eclipse-platform#3339 Assisted-by: multiple AI agents and layers of automated tooling 🤖
vogella
force-pushed
the
cocoa-accessible-string-range-3339
branch
from
October 9, 2026 17:53
81ff645 to
0ffa296
Compare
Contributor
Test Results (macosx) 76 files 76 suites 5m 47s ⏱️ Results for commit 0ffa296. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessibility clients such as VoiceOver ask for text ranges and indexes past the end of a control's text. The Cocoa Accessible passed them straight to substring, so the string for range, selected text and line for index queries threw StringIndexOutOfBoundsException, and the attributed string query looped forever because the style runs never reached the requested end. The ranges are now clamped to the text, and a Cocoa regression test covers all four queries. This builds on #3715 (the JUnit 5 move of the Cocoa test bundle), whose commit is included here until it is merged.
Fixes #3339