-
Notifications
You must be signed in to change notification settings - Fork 163
[GTK] Don't use deprecated gtk_style_context_invalidate() #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GTK] Don't use deprecated gtk_style_context_invalidate() #915
Conversation
197c868
to
b61252c
Compare
GTK sources say: Deprecated: 3.12: Style contexts are invalidated automatically. https://www.eclipse.org/swt/faq.php#gtkstartup says: Eclipse/SWT 4.16.x: GTK+ 3.20.0 and its dependencies Eclipse/SWT 4.15.x: GTK+ 3.14.0 and its dependencies This means that it's been at least 3 years since SWT requires GTK 3.20. Sounds safe to stop using the deprecated function now. Signed-off-by: Alexandr Miloslavskiy <[email protected]>
b61252c
to
fed0eb7
Compare
Unfortunately it didn't fix #697. |
Note: there were no one successful gerrit build for this PR: This (among other issues) caused errors in building SWT GTK related code, see eclipse-platform/eclipse.platform.releng.aggregator#1608. I assume version updates are missing for GTK fragments, but I'm not sure. I'm looking into this. |
https://download.eclipse.org/eclipse/downloads/drops4/I20231129-0600/buildlogs/reporeports/reports/versionChecks.html shows that both swt host and fragments have version updates. |
OK, the diff shows that bytecode change is related to this PR. The new version is what we actually should use. So if the versions are bumped, why do we have the problem? |
The API errors are reported because classes & sources changed in
Here the excerpt:
|
I will now touch the 3 fragments, if that is the way to go. |
GTK sources say:
Deprecated: 3.12: Style contexts are invalidated automatically.
https://www.eclipse.org/swt/faq.php#gtkstartup says:
Eclipse/SWT 4.16.x: GTK+ 3.20.0 and its dependencies
Eclipse/SWT 4.15.x: GTK+ 3.14.0 and its dependencies
This means that it's been at least 3 years since SWT requires GTK 3.20. Sounds safe to stop using the deprecated function now.
Hopefully fixes #697 I couldn't reproduce it in SWT snippet, so I didn't test this with SWT. But when I tested in native snippet, removing
gtk_style_context_invalidate()
changed things a bit and crash no longer occurred.