Hide ExpandableNode from client's label provider. #1354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iloveeclipse FYI |
iloveeclipse
approved these changes
Nov 30, 2023
Unsafe(No type check before accessing passed model element) client's label provider can lead to ClassCastException. So we can never pass ExpandableNode to client's label provider. see eclipse-platform#1353
iloveeclipse
force-pushed
the
hide_exp_node_lp_1353
branch
from
d0e3570 to
dce752d
Compare
|
Tests fails are known & unrelated, see #1351 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsafe(No type check before accessing passed model element) client's label provider can lead to ClassCastException. So we can never pass ExpandableNode to client's label provider.
see #1353