Revert highlighting fix #1957
Revert highlighting fix #1957
Conversation
|
You cannot revert bundle versions for published bundles! |
|
We have IBuild there with these versions. @merks : WDYT, should we mark it unstable and revert versions, or better don't try to revert versions? |
|
Please don't revert versions, everyone that already updated to latest I-build (I am aware and will redownload myself but others might not be) will not get updates. |
fedejeanne
force-pushed
the
revert_highlighting_fix
branch
from
0b0f492 to
22dcffa
Compare
👍 |
|
Yes, please don't revert versions. These things have already escape and I are my pool. Also, I think we can assume this will eventually be fixed properly and hence all the bundle will be incremented at some point in the not-to-distant future. |
@merks versions should be as published now --> 22dcffa
I'd say it should be possible to wait until later today to apply this PR and give @BeckerWdf / @Christopher-Hermann some time to find a better fix. @iloveeclipse would that be ok for you? Since you are in Linux, you are seeing the problems in your IDE already. Colors can be changed though (see #1690 (comment)), so it should be endurable for a couple of hours (?) |
Hm, on a second thought, this means that not only should I not revert (decrease) versions but I should actually increase versions, right @akurtakov ? I mean those who already updated their IDE and have #1690 in it should be able to get an update with #1957 (this PR) tomorrow. I'll increase versions in a separate commit in a minute. |
|
Yes, you should keep the versions as they are. They should end up with a new qualifier in a new build via the other revert commit in the projects. |
No need to modify the x.y.z, the version qualifier will be increased at build-time because as it will be updated with the commit merge date, which would be newer. |
|
I'm okay with not doing a revert at all if this can be addressed in the next few hours. Yesterday when was testing the removal of a feature, the build itself took like 3.5 hours and then the testing seemed to take another 4, so there is along delay between when you might commit a revert (without reverting versions) and a build from that being available. |
Just in case the rapid responses are not 100% clear, the idea is to revert everything except the version changes and as @mickaelistria correctly points out, this will result in new qualifier versions so that we can update to the reverted versions. Hopefully the problem is just fixed very quickly... I'm out for a few hours, otherwise I could test that the installer works with whatever fixes are being applied... |
eclipse-platform/eclipse.platform.swt#811" This reverts commit cbda3bc. Bundle versions are not reverted.
fedejeanne
force-pushed
the
revert_highlighting_fix
branch
from
22dcffa to
537394a
Compare
Test Results 1 510 files + 300 1 510 suites +300 1h 11m 26s ⏱️ + 19m 5s Results for commit 537394a. ± Comparison against base commit 521543f. This pull request removes 5 tests.This pull request skips 1 test. |
|
On Linux (and probably on other OSes) we have more problems that needs a fix: #1956 (wrong selection color, missing selection icon, missing foreground coloring on trees). @Christopher-Hermann : if you could fix all of them today till evening, I can validate your fixes. |
Let's merge this revert. I will not mange to fix the issues by today. |
|
FWIW, I strongly recommend testing colors issues/changes with both theming engine enabled and disabled, IMO it does a lot more than needed trying to workaround issues on lower lever thus breaking UI when an issue underneath is fixed. |
Exact. This is what I did on #1956 and the problem appears in both modes. |
|
I've quickly tested this PR and it fixes all the issues I've reported in #1956. So let's merge. |
|
Should I trigger another IBuild now to see the real test results without JFace related errors? |
|
Yes please. |
Revert #1690
Due to #1955 , #1956 , eclipse-platform/eclipse.platform.swt#1275