Skip to content

Add required capability for SVG support to org.eclipse.ui #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

HeikoKlare
Copy link
Contributor

In order to use SVGs as icons, an according rasterizer has to be present. This is achieved by adding an according required OSGi capability.

In order to prevent issues that we had for SWT tests (eclipse-platform/eclipse.platform.swt#1944) also in production code, I propose to add the required capability to one of the UI bundles that will contain SVG before actually adding them. This is supposed to avoid that it breaks the build or the generated products because the according rasterizer fragment might be missing in the deployed products (runtime, SDK).

HeikoKlare and others added 2 commits March 28, 2025 17:33
In order to use SVGs as icons, an according rasterizer has to be
present. This is requested by an according OSGi capability, which is
added to the org.eclipse.ui bundle by this change.
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From e5752062bb1eac9004845a91f113f8a2208f8156 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Fri, 28 Mar 2025 16:39:09 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/bundles/org.eclipse.ui/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui/META-INF/MANIFEST.MF
index 997781ebbf..ba6652149d 100644
--- a/bundles/org.eclipse.ui/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui; singleton:=true
-Bundle-Version: 3.207.100.qualifier
+Bundle-Version: 3.207.200.qualifier
 Bundle-Activator: org.eclipse.ui.internal.UIPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %Plugin.providerName
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

github-actions bot commented Mar 28, 2025

Test Results

 1 824 files  ±0   1 824 suites  ±0   1h 29m 43s ⏱️ - 8m 16s
 7 918 tests ±0   7 689 ✅  - 1  228 💤 ±0  1 ❌ +1 
23 841 runs  ±0  23 092 ✅  - 1  748 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 1a7d4df. ± Comparison against base commit b6af990.

♻️ This comment has been updated with latest results.

@HeikoKlare
Copy link
Contributor Author

Closing this as obsolete. Has been tested via eclipse-platform/eclipse.platform.releng.aggregator#2957

According required capabilities need to be added via SVG-adding PRs to the affected bundles, such as in:

@HeikoKlare HeikoKlare closed this Mar 30, 2025
@HeikoKlare HeikoKlare deleted the svg-capability-org.eclipse.ui branch March 30, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants