[Find/Replace dialog][Linux] "Replace" buttons remain disabled when using "Enter"

[iloveeclipse]

Fixes #2880

[github-actions]

Test Results

 1 824 files  ±0   1 824 suites  ±0   1h 32m 3s ⏱️ - 12m 1s
 7 918 tests ±0   7 690 ✅ ±0  228 💤 ±0  0 ❌ ±0 
23 841 runs  ±0  23 093 ✅ ±0  748 💤 ±0  0 ❌ ±0 

Results for commit 97630a6. ± Comparison against base commit cae93a3.

♻️ This comment has been updated with latest results.

[HeikoKlare]

It might be that something has been mixed up in this handler by all the recent changes (including mine extracting the update of the button state from the handler). This change actually looks reasonable, but it will probably result in the same state of the code we had when this issue was reported:

• [Find/Replace] changed search string is ignored by search dialog #2322

And that issue was fixed by moving the modification handler around (in the opposite direction as done by this change):

• Find/replace dialog: properly update search string #2322 #2327

I can have a look at that once I am back from travel (on Thursday). If someone wants to reevaluate this change with the above mentioned information, feel free to do so.

[iloveeclipse]

Thanks Heiko, if I will have time tomorrow, I will check which workaround for which regression caused which problem.

[HeikoKlare]

@iloveeclipse I have checked the implementation and the existing workaround again and this is my understanding how it has to behave:

• the data passed to the underlying FindReplaceLogic (find and replace string) always have to updated when the modification listener is called
• the button state must only be updated on the second call of the listener on Linux (that's the existing workaround)
  That's
  Since the listener is parameterized with both these kinds of operations, which have to be called under different conditions, they cannot be combined in a single handler as they are right now. One solution is to extend the listener parameterization to take two callbacks, one for each of the above mentioned situations.

I have just pushed according changes to the PR branch for demonstration purposes. In my opinion that should solve all mentioned issues. Feel free to adapt/revert/merge them as desired and required. I will leave for vacation now, so I will probably not be able to contribute further to this for the next week, but I hope the above mentioned helps to finalize the fix.

[iloveeclipse]

@HeikoKlare : thanks, it works, I've verified that.