Skip to content

Remove obsolete fail statements in org.eclipse.ui.tests #3171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

HeikoKlare
Copy link
Contributor

Several test methods in org.eclipse.ui.tests catch exceptions to then simply fail with the message of that same exception. With this change, the test methods are adapted to directly throw those exceptions so simplify the test implementation and remove obsolete fail statements.

@HeikoKlare HeikoKlare force-pushed the obsolete-fail-org.eclipse.ui.tests branch 5 times, most recently from 8711950 to 9364a17 Compare August 13, 2025 19:59
Copy link
Contributor

github-actions bot commented Aug 13, 2025

Test Results

 2 778 files  ±0   2 778 suites  ±0   1h 45m 57s ⏱️ - 1m 50s
 7 932 tests ±0   7 704 ✅ +2  228 💤 ±0  0 ❌  - 2 
23 349 runs  ±0  22 603 ✅ +2  746 💤 ±0  0 ❌  - 2 

Results for commit d99546d. ± Comparison against base commit 82d778f.

♻️ This comment has been updated with latest results.

Several test methods in org.eclipse.ui.tests catch exceptions to then
simply fail with the message of that same exception. With this change,
the test methods are adapted to directly throw those exceptions so
simplify the test implementation and remove obsolete fail statements.
@HeikoKlare HeikoKlare force-pushed the obsolete-fail-org.eclipse.ui.tests branch from 9364a17 to d99546d Compare August 13, 2025 21:56
@akurtakov akurtakov merged commit 805b5b9 into eclipse-platform:master Aug 14, 2025
18 checks passed
@HeikoKlare HeikoKlare deleted the obsolete-fail-org.eclipse.ui.tests branch August 14, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants