Skip to content

Move ScopedPreferenceStore to org.eclipse.jface #4262 #4270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptziegler wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Move ScopedPreferenceStore to org.eclipse.jface #4262 #4270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f7b527
Move `ScopedPreferenceStore` to `org.eclipse.jface` #4262
ptziegler Aug 21, 2026
69648cd
Restore dummy `ScopedPreferenceStore` for backwards compatibility #4262
ptziegler Aug 21, 2026
f52f4de
Version bump(s) for 4.41 stream
eclipse-platform-bot Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bundles/org.eclipse.jface/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ Export-Package: org.eclipse.jface,
Require-Bundle: org.eclipse.swt;bundle-version="[3.126.0,4.0.0)";visibility:=reexport,
org.eclipse.core.commands;bundle-version="[3.4.0,4.0.0)";visibility:=reexport,
org.eclipse.equinox.common;bundle-version="[3.18.0,4.0.0)",
org.eclipse.equinox.bidi;bundle-version="[0.10.0,2.0.0)";resolution:=optional
org.eclipse.equinox.bidi;bundle-version="[0.10.0,2.0.0)";resolution:=optional,
org.eclipse.equinox.preferences;bundle-version="[3.12.100,4.0.0)"

@laeubi laeubi Aug 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As ScopedPreferenceStore is the only consumer we can make this optional, even though I generally try to avoid this, it would not introduce any new dependency.

If preferences does not contain a split package, an import-package might be more suitable here.

Bundle-RequiredExecutionEnvironment: JavaSE-21
Import-Package: javax.xml.parsers,
org.osgi.framework;version="[1.8.0,2.0.0)",
Expand Down
5 changes: 5 additions & 0 deletions bundles/org.eclipse.jface/src/org/eclipse/jface/messages.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,3 +236,8 @@ ConfigureColumnsDialog_down = Dow&n
# org.eclipse.jface.viewers.internal.ExpandableNode
ExpandableNode.defaultLabel = Show next {0} items from remaining {1}
ExpandableNode.showRemaining = Show remaining {0} item{1}

#############################################################
# org.eclipse.jface.preference.ScopedPreferenceStore
#############################################################
ScopedPreferenceStore_DefaultAddedError=Do not add the default to the search contexts
Loading
Loading