Fix varargs type mismatch in NLS.bind invocation

[SougandhS]

Replace String[] array with individual Object arguments in NLS.bind calls to resolve type mismatch warnings

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ant/org.eclipse.ant.core/META-INF/MANIFEST.MF
debug/org.eclipse.core.externaltools/META-INF/MANIFEST.MF
debug/org.eclipse.core.variables/META-INF/MANIFEST.MF
team/bundles/org.eclipse.compare.core/META-INF/MANIFEST.MF
update/org.eclipse.update.configurator/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From e7b162c8bc8fc8b379bfe440ff4fe43df2edf76a Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 5 May 2025 11:21:30 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/ant/org.eclipse.ant.core/META-INF/MANIFEST.MF b/ant/org.eclipse.ant.core/META-INF/MANIFEST.MF
index e4fcb869a7..7589c7ab2d 100644
--- a/ant/org.eclipse.ant.core/META-INF/MANIFEST.MF
+++ b/ant/org.eclipse.ant.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ant.core; singleton:=true
-Bundle-Version: 3.7.600.qualifier
+Bundle-Version: 3.7.700.qualifier
 Bundle-Activator: org.eclipse.ant.core.AntCorePlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/debug/org.eclipse.core.externaltools/META-INF/MANIFEST.MF b/debug/org.eclipse.core.externaltools/META-INF/MANIFEST.MF
index 169587e22e..2be9d48ae2 100644
--- a/debug/org.eclipse.core.externaltools/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.core.externaltools/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-Localization: plugin
 Bundle-SymbolicName: org.eclipse.core.externaltools;singleton:=true
-Bundle-Version: 1.3.400.qualifier
+Bundle-Version: 1.3.500.qualifier
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
  org.eclipse.debug.core;bundle-version="[3.9.0,4.0.0)",
  org.eclipse.core.variables;bundle-version="[3.2.800,4.0.0)"
diff --git a/debug/org.eclipse.core.variables/META-INF/MANIFEST.MF b/debug/org.eclipse.core.variables/META-INF/MANIFEST.MF
index 6d627132b8..a106108427 100644
--- a/debug/org.eclipse.core.variables/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.core.variables/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.core.variables; singleton:=true
-Bundle-Version: 3.6.500.qualifier
+Bundle-Version: 3.6.600.qualifier
 Bundle-Activator: org.eclipse.core.variables.VariablesPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/team/bundles/org.eclipse.compare.core/META-INF/MANIFEST.MF b/team/bundles/org.eclipse.compare.core/META-INF/MANIFEST.MF
index 001bf0db3a..b887b38580 100644
--- a/team/bundles/org.eclipse.compare.core/META-INF/MANIFEST.MF
+++ b/team/bundles/org.eclipse.compare.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.compare.core
-Bundle-Version: 3.8.700.qualifier
+Bundle-Version: 3.8.800.qualifier
 Bundle-Vendor: %providerName
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)"
 Bundle-RequiredExecutionEnvironment: JavaSE-17
diff --git a/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF b/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
index 5f045c7318..f1a5deb034 100644
--- a/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
+++ b/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.update.configurator; singleton:=true
-Bundle-Version: 3.5.600.qualifier
+Bundle-Version: 3.5.700.qualifier
 Bundle-Activator: org.eclipse.update.internal.configurator.ConfigurationActivator
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

[github-actions]

Test Results

 1 758 files  ±0   1 758 suites  ±0   1h 24m 24s ⏱️ +24s
 4 173 tests ±0   4 150 ✅ ±0   23 💤 ±0  0 ❌ ±0 
13 119 runs  ±0  12 952 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit d651e66. ± Comparison against base commit d239749.

♻️ This comment has been updated with latest results.

[SougandhS]

Hi @HannesWell , could you please check this PR when you have some time ?

[SougandhS]

Hi @HannesWell , could you please check this PR when you have some time ?

All binding changes has been handled

[HannesWell]

Thank you @SougandhS for fixing all these warnings. I should have had a broader look at warnings but I have now created a follow-up that avoids these warnings:

• Make var-args overload of NLS.bind() generic eclipse-equinox/equinox#939

Actually, as mentioned in eclipse-equinox/equinox#936 (comment), I wanted to use/test our automated clean-up job to perform the removal of the unnecessary array creations.
I don't want to reject your work just, for that, but I would still like the clean-up job to create a PR first just to compare the result of your work and that job. But it might prolong the review by a few days.
But the warnings should be gone sooner.

[SougandhS]

Thank you @SougandhS for fixing all these warnings. I should have had a broader look at warnings but I have now created a follow-up that avoids these warnings:

• Make var-args overload of NLS.bind() generic eclipse-equinox/equinox#939

Actually, as mentioned in eclipse-equinox/equinox#936 (comment), I wanted to use/test our automated clean-up job to perform the removal of the unnecessary array creations. I don't want to reject your work just, for that, but I would still like the clean-up job to create a PR first just to compare the result of your work and that job. But it might prolong the review by a few days. But the warnings should be gone sooner.

Thanks, I’ll keep an eye out for the PR from the cleanup job 👍