Compare/Replace selection or editor with clipboard

[SougandhS]

This feature will allow users to compare either the selected text or the entire editor content against the current clipboard contents similar to other IDEs.





If users want to just compare just a selection in an editor, select the section and choose Compare with-> Clipboard
(I had changes copied..)

Selection.mp4

Selection2.mp4

If User want to compare entire Editor, either select all or select None and choose _Compare with-> Clipboard_

Entire.mp4

[github-actions]

Test Results

 1 764 files  ±0   1 764 suites  ±0   1h 31m 34s ⏱️ - 14m 23s
 4 381 tests ±0   4 357 ✅ +1   24 💤 ±0  0 ❌  - 1 
13 143 runs  ±0  12 976 ✅ +1  167 💤 ±0  0 ❌  - 1 

Results for commit 73d7e06. ± Comparison against base commit 2e1acee.

♻️ This comment has been updated with latest results.

[SougandhS]

Hi @iloveeclipse
Could you please check this when you have some time ?

[iloveeclipse]

I'm biased here, since this feature is provided by AnyEdit Tools plugin since years:
https://marketplace.eclipse.org/content/anyedit-tools

[SougandhS]

I'm biased here, since this feature is provided by AnyEdit Tools plugin since years: https://marketplace.eclipse.org/content/anyedit-tools

but having it built directly into Eclipse makes it easier and more consistent for users—no need to install or manage extra plugins just to do something that feels like it should be built-in

[vogella]

In my testing this does not reliable work.

For example in copy f.application from this file:

Now I select a java file and select Compare With -> Clipboard nothing happens.

[iloveeclipse]

Why not let this feature be in AnyEdit plugin? It's tested, has more features etc.

[vogella]

Why not let this feature be in AnyEdit plugin? It's tested, has more features etc.

Having it in standard is desired for such a useful and core feature. Also I don't think every user has AnyEdit installed, for example I think I never did install it.

[iloveeclipse]

I would expect then that this contribution would add same functionality AnyEdit provides for clipboard, means also context menus for files in Package Explorer, not just "Compare with..." but also "Replace with.." etc.

[SougandhS]

In my testing this does not reliable work.
For example in copy f.application from this file:

This is fixed now

[SougandhS]

I would expect then that this contribution would add same functionality AnyEdit provides for clipboard, means also context menus for files in Package Explorer, not just "Compare with..." but also "Replace with.." etc.

Sure. i'll add Replace with clipboard feature too 👍

[vogella]

I would expect then that this contribution would add same functionality AnyEdit provides for clipboard, means also context menus for files in Package Explorer, not just "Compare with..." but also "Replace with.." etc.

Sure. i'll add Replace with clipboard feature too 👍

Thanks. Next issue I see, is that it seems that I can also do this compare once. I tested my scenario above. After that I copied some source code from the compare editor and did the compare on another file. Nothing happens.

[SougandhS]

Next issue I see, is that it seems that I can also do this compare once. I tested my scenario above. After that I copied some source code from the compare editor and did the compare on another file. Nothing happens.

This is fixed now + Added replace with clipboard functionality + Compare/Replace from Project/Package exp context menu

Replace_1.mp4

Replace_2.mp4

[vogella]

Calling compare on some files switching the project results in the following exception for me:

java.lang.NullPointerException: Cannot invoke "String.getBytes(java.nio.charset.Charset)" because "this.content" is null
at org.eclipse.compare.internal.ClipboardCompare$1ClipboardTypedElement.getContents(ClipboardCompare.java:148)
at org.eclipse.compare.internal.CompareUIPlugin.getContentType(CompareUIPlugin.java:1227)
at org.eclipse.compare.internal.CompareUIPlugin.getCommonType(CompareUIPlugin.java:1280)
at org.eclipse.compare.internal.CompareUIPlugin.findStructureViewerDescriptor(CompareUIPlugin.java:824)
at org.eclipse.compare.internal.CompareUIPlugin.findStructureViewer(CompareUIPlugin.java:867)
at org.eclipse.compare.CompareUI.findStructureViewer(CompareUI.java:321)
at org.eclipse.compare.CompareEditorInput.findStructureViewer(CompareEditorInput.java:893)
at org.eclipse.compare.internal.CompareStructureViewerSwitchingPane.getViewer(CompareStructureViewerSwitchingPane.java:87)
at org.eclipse.compare.CompareEditorInput$2.getViewer(CompareEditorInput.java:684)
at org.eclipse.compare.CompareViewerSwitchingPane.setInput(CompareViewerSwitchingPane.java:258)
at org.eclipse.compare.internal.CompareStructureViewerSwitchingPane.setInput(CompareStructureViewerSwitchingPane.java:140)
at org.eclipse.compare.CompareEditorInput.feedInput(CompareEditorInput.java:716)
at org.eclipse.compare.CompareEditorInput.createContents(CompareEditorInput.java:543)
at org.eclipse.compare.internal.CompareEditor.createCompareControl(CompareEditor.java:448)
at org.eclipse.compare.internal.CompareEditor.createPartControl(CompareEditor.java:400)
at org.eclipse.ui.internal.e4.compatibility.CompatibilityPart.createPartControl(CompatibilityPart.java:160)
at org.eclipse.ui.internal.e4.compatibility.CompatibilityEditor.createPartControl(CompatibilityEditor.java:96)
at org.eclipse.ui.internal.e4.compatibility.CompatibilityPart.create(CompatibilityPart.java:367)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)

[SougandhS]

Calling compare on some files switching the project results in the following exception for me:

java.lang.NullPointerException: Cannot invoke "String.getBytes(java.nio.charset.Charset)" because "this.content" is null at org.eclipse.compare.internal.ClipboardCompare$1ClipboardTypedElement.getContents(ClipboardCompare.java:148) at org.eclipse.compare.internal.CompareUIPlugin.getContentType(CompareUIPlugin.java:1227) at org.eclipse.compare.internal.CompareUIPlugin.getCommonType(CompareUIPlugin.java:1280) at org.eclipse.compare.internal.CompareUIPlugin.findStructureViewerDescriptor(CompareUIPlugin.java:824) at org.eclipse.compare.internal.CompareUIPlugin.findStructureViewer(CompareUIPlugin.java:867) at org.eclipse.compare.CompareUI.findStructureViewer(CompareUI.java:321) at org.eclipse.compare.CompareEditorInput.findStructureViewer(CompareEditorInput.java:893) at org.eclipse.compare.internal.CompareStructureViewerSwitchingPane.getViewer(CompareStructureViewerSwitchingPane.java:87) at org.eclipse.compare.CompareEditorInput$2.getViewer(CompareEditorInput.java:684) at org.eclipse.compare.CompareViewerSwitchingPane.setInput(CompareViewerSwitchingPane.java:258) at org.eclipse.compare.internal.CompareStructureViewerSwitchingPane.setInput(CompareStructureViewerSwitchingPane.java:140) at org.eclipse.compare.CompareEditorInput.feedInput(CompareEditorInput.java:716) at org.eclipse.compare.CompareEditorInput.createContents(CompareEditorInput.java:543) at org.eclipse.compare.internal.CompareEditor.createCompareControl(CompareEditor.java:448) at org.eclipse.compare.internal.CompareEditor.createPartControl(CompareEditor.java:400) at org.eclipse.ui.internal.e4.compatibility.CompatibilityPart.createPartControl(CompatibilityPart.java:160) at org.eclipse.ui.internal.e4.compatibility.CompatibilityEditor.createPartControl(CompatibilityEditor.java:96) at org.eclipse.ui.internal.e4.compatibility.CompatibilityPart.create(CompatibilityPart.java:367) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) at java.base/java.lang.reflect.Method.invoke(Method.java:580)

Strange. I'll provide null check for it

[SougandhS]

Calling compare on some files switching the project results in the following exception for me:
java.lang.NullPointerException: Cannot invoke "String.getBytes(java.nio.charset.Charset)" because "this.content" is null at

Reproduced and handled this now

[vogella]

Testing this again.

I don't think compare is correct for this example:

• Create a text file, in my example lars.adoc with the following content:

lars
testing
compare
asdfklklsdf

• Copy the last two lines into the clipbard.
• Select the file and select compare with clipboard
• Result:

@SougandhS please have a look

[SougandhS]

@SougandhS please have a look

Thanks for this case. Its fixed now

bugfix.mp4