Skip to content

Add N&N for SVG support #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

Conversation

Michael5601
Copy link
Contributor

This PR contributes an N&N informing about the support of SVGs for loading images in Eclipse.

See eclipse-platform/eclipse.platform.swt#1638.

@Michael5601
Copy link
Contributor Author

I will change the screenshots to light mode after we discussed if these screenshots are appropriate. On Windows Eclipse now uses the "smooth" scaling as default. The screenshots I provided still use the "nearest" scaling method so the difference in comparison to SVGs is way bigger.

This contributes an N&N informing about the support of SVGs for loading images in Eclipse.

See eclipse-platform/eclipse.platform.swt#1638.
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have slightly updated the entry and added information about the de-facto deprecation of the replaced PNG images and their potential removal with Eclipse 2027-06 or later.

The screenshots are fine for me. Also comparing with nearest scaling makes sense to me as that's what users were used to and a comparison with smooth scaling will not so much show a visible difference. And anyway, it's not only about improved look but also about more flexibility, reduced development efforts etc.
I have replaced the images with light mode ones at the same sizes. I also clarifies that the PNG-based images are taken with scaling mode nearest.

@HeikoKlare
Copy link
Contributor

Thank you for providing the news entry, @Michael5601!

@HeikoKlare HeikoKlare merged commit 44a380d into eclipse-platform:master May 6, 2025
1 check passed
@HeikoKlare HeikoKlare linked an issue May 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create news for SVG support in Eclipse
2 participants