fix (IC): Fixed two broken links to OpenAPI specification for Unique ID Push [GH-1068]#1104
Closed
markuskeidl wants to merge 1 commit intoeclipse-tractusx:mainfrom
Closed
fix (IC): Fixed two broken links to OpenAPI specification for Unique ID Push [GH-1068]#1104markuskeidl wants to merge 1 commit intoeclipse-tractusx:mainfrom
markuskeidl wants to merge 1 commit intoeclipse-tractusx:mainfrom
Conversation
This was referenced Dec 3, 2024
Contributor
Author
|
Not sure about the changelog - I created it in a way that this should go into 25.03. If we want to integrate it now, the entry has to be changed to release a version 1.2.1 or something like that. |
jSchuetz88
suggested changes
Dec 21, 2024
Member
There was a problem hiding this comment.
Thank you @markuskeidl for fixing this issue. I have only one minor remark:
- There seems to be a conflict with the changelog. The current version of the changelog is 1.3.0 (See here. As a Patch, the version of this change should be 1.3.1
- Additionally, as this change fixes an issue which is also part of the R24.12 release. Could you also add this change to the R24.12 version? (./docs-kits_versioned_docs/version-24.12 /kits/...)
Contributor
Author
|
I updated links for release 25.03 to point to the API-Hub: #1158. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes dead links in Industry Core KIT as reported here: #1068
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: