feat: Add verify headers workflow #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is really cool! we should probably include this into sig-infra maybe... I approve it ;) |
matbmoser
requested changes
Feb 17, 2025
.github/workflows/verify.yml
Outdated
Comment on lines
59
to
65
| allow-licenses: >- | ||
| Adobe-Glyph, Apache-1.0, Apache-1.1, Apache-2.0, Artistic-2.0, BSD-2-Clause, BSD-3-Clause, | ||
| BSD-4-Clause, 0BSD, BSL-1.0, CDDL-1.0, CDDL-1.1, CPL-1.0, CC-BY-3.0, CC-BY-4.0, CC-BY-2.5, | ||
| CC-BY-SA-3.0, CC-BY-SA-4.0, CC0-1.0, EPL-1.0, EPL-2.0, FTL, GFDL-1.3-only, IPL-1.0, ISC, | ||
| MIT, MIT-0, MPL-1.1, MPL-2.0, NTP, OpenSSL, PHP-3.01, PostgreSQL, OFL-1.1, Unlicense, | ||
| Unicode-DFS-2015, Unicode-DFS-2016, Unicode-TOU, UPL-1.0, W3C-20150513, W3C-19980720, W3C, | ||
| WTFPL, X11, Zlib, ZPL-2.1, AGPL-3.0 |
There was a problem hiding this comment.
Just a little question here, is this for dash? or is also for the header? in code just apache is needed
There was a problem hiding this comment.
This is more from the dash side; perhaps the dependencies workflow in #51 is enough
There was a problem hiding this comment.
Ok but in general is not a bad idea, lets keep it.
CDiezRodriguez
force-pushed
the
feat/add-verify-headers
branch
from
34a6ade to
0fd10dd
Compare
|
matbmoser
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Adds a header license checker workflow.
WHY
To ensure that all files have the correct license header.
FURTHER NOTES
Relates to #63