Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add asr endpoints, dockerfiles and helm chart #14

Merged
merged 32 commits into from
Jun 17, 2024
Merged

feat: add asr endpoints, dockerfiles and helm chart #14

merged 32 commits into from
Jun 17, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Mar 5, 2024 •
edited by evegufy
Loading

Description

  • add get endpoint for credentials
  • add swagger
  • add post endpoint to validate json schemas
  • add dockerfiles, helm chart and environment configuration
  • improve GH workflows
  • improve docs

Why

To enable implementation for SSI Authority & Schema Registry.

Issue

#7 #11 #13

Issue for Sonarcloud enabling: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4732

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 changed the base branch from dev to main March 5, 2024 10:06
@Phil91 Phil91 force-pushed the feature/11-schema-validation branch from ab55b55 to 79221ca Compare March 5, 2024 10:08
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

This was linked to issues Mar 5, 2024
Authority & Schema Registry - API Endpoin #1 #4
Closed
Authority & Schema Registry - Allow the credential schema pull/push #11
Closed
@Phil91 Phil91 force-pushed the feature/11-schema-validation branch from 79221ca to 63d0831 Compare March 5, 2024 10:10
@Phil91 Phil91 force-pushed the feature/11-schema-validation branch from 63d0831 to e62f3e3 Compare March 5, 2024 10:13
@Phil91 Phil91 force-pushed the feature/11-schema-validation branch from e62f3e3 to c6fd82f Compare April 4, 2024 11:27
@Phil91 Phil91 force-pushed the feature/11-schema-validation branch 2 times, most recently from 788f458 to 19086f2 Compare May 29, 2024 08:54
@Phil91 Phil91 force-pushed the feature/11-schema-validation branch from 19086f2 to a2bd9e4 Compare May 30, 2024 07:27
@Phil91 Phil91 mentioned this pull request May 30, 2024
Closed
8 tasks
@Phil91 Phil91 force-pushed the feature/11-schema-validation branch 4 times, most recently from 3662c67 to e1f70e2 Compare May 30, 2024 11:34
@Phil91 Phil91 requested review from evegufy and ntruchsess May 31, 2024 07:46
@Phil91 Phil91 force-pushed the feature/11-schema-validation branch from e1f70e2 to dc1f68c Compare June 13, 2024 10:37
Phil91 added 3 commits June 13, 2024 14:19
@Phil91
feat(db): add database schema
ca99bc8 
Refs: #7
@Phil91
feat(api): add schema validation endpoint
f338a4a 
add get endpoint for credentials
add swagger
add post endpoint to validate json schemas

Refs: #4 #6 #11
@Phil91
build: add chart
46c7180
@Phil91 Phil91 force-pushed the feature/11-schema-validation branch from dc1f68c to 46c7180 Compare June 13, 2024 12:21
@Phil91 Phil91 force-pushed the feature/11-schema-validation branch from 8da8a83 to b5e91ba Compare June 14, 2024 10:52
@Phil91 Phil91 force-pushed the feature/11-schema-validation branch from b5e91ba to f2afe32 Compare June 14, 2024 11:30
@evegufy
Copy link
Contributor

evegufy commented Jun 14, 2024

@Phil91 could you please also enable sonarcloud, see ssi issuer issue https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4403

evegufy
evegufy previously approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, please still update PR title and description

@Phil91 Phil91 changed the title feat(api): add schema validation endpoint feat(api): add asr endpoints, chart and environment configuration Jun 14, 2024
@evegufy evegufy changed the title feat(api): add asr endpoints, chart and environment configuration feat(api): add asr endpoints, dockerfiles and helm chart Jun 17, 2024
@evegufy evegufy changed the title feat(api): add asr endpoints, dockerfiles and helm chart feat: add asr endpoints, dockerfiles and helm chart Jun 17, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 17, 2024
View reviewed changes
src/registry/SsiAuthoritySchemaRegistry.Service/appsettings.json
"AllowedOrigins": []
},
"ConnectionStrings": {
"RegistryDb": "Server=placeholder;Database=placeholder;Port=5432;User Id=placeholder;Password=;Ssl Mode=Disable;"

Check failure

Code scanning / SonarCloud

A secure password should be used when connecting to a database

<!--SONAR_ISSUE_KEY:AZAlNVC_bZS5gdZG5k58-->Use a secure password when connecting to this database. <p>See more on <a href="https://sonarcloud.io/project/issues?id=eclipse-tractusx_ssi-authority-schema-registry&issues=AZAlNVC_bZS5gdZG5k58&open=AZAlNVC_bZS5gdZG5k58&pullRequest=14">SonarCloud</a></p>
@Phil91 Phil91 requested review from ntruchsess and evegufy June 17, 2024 09:02
evegufy
evegufy previously approved these changes Jun 17, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
4 Accepted issues

Measures
0 Security Hotspots
88.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Phil91 Phil91 merged commit dd952b0 into main Jun 17, 2024
11 checks passed
@Phil91 Phil91 deleted the feature/11-schema-validation branch June 17, 2024 13:48
@github-actions github-actions bot mentioned this pull request Jul 16, 2024
Merged
@github-actions github-actions bot mentioned this pull request Nov 11, 2024
Merged
@github-actions github-actions bot mentioned this pull request Feb 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

@evegufy evegufy evegufy approved these changes

Assignees

@ntruchsess ntruchsess

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Phil91 @evegufy @ntruchsess