Skip to content

Conversation

@saudkhan116
Copy link

@saudkhan116 saudkhan116 commented Jul 4, 2025

Description

This PR introduces:

  • The Industry Flags Service (IFS) codebase to enable users and systems to retrieve corporate industry information

  • The workflows to build and publish docker images for: ifs-frontend, ifs-backend, test-orchestrator, dt-pull-service

  • Initial configuration of the IFS

  • IFS backend integration to the following tractusx-sdk APIs:

    • idpManager -> OAuth2Manager
    • oauthManager -> AuthManager
    • edcDiscoveryService -> ConnectorDiscoveryService
    • edcService -> ConnectorService
  • Removed the following files:

    • discoveryServices
    • authManager.py
    • idpManager.py

Issues Linked

PR Linked

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@matbmoser matbmoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the latest version of the SDK, v0.1.0. There is a edcService ready with the code from here

import it with the pip.

also it is now going to have also the discovery services from here + bpn discovery: eclipse-tractusx/tractusx-sdk#121

@matbmoser
Copy link
Contributor

@saudkhan116 how far is this developement

@saudkhan116 saudkhan116 requested a review from matbmoser October 10, 2025 15:59
# SPDX-License-Identifier: Apache-2.0
#################################################################################

FROM alpine:3.19

Check notice

Code scanning / KICS

Healthcheck Instruction Missing Note

Dockerfile doesn't contain instruction 'HEALTHCHECK'
RUN ls -la

## Install Python
RUN apk add python3 py3-pip libpq --no-cache

Check warning

Code scanning / KICS

Unpinned Package Version in Apk Add Warning

RUN instruction apk add python3 py3-pip libpq --no-cache does not use package pinning form
VOLUME ./data ./logs

## Create the directories
RUN mkdir -p ./logs

Check notice

Code scanning / KICS

Multiple RUN, ADD, COPY, Instructions Listed Note

There are RUN instructions that could be grouped



FROM nginxinc/nginx-unprivileged:alpine

Check notice

Code scanning / KICS

Healthcheck Instruction Missing Note

Dockerfile doesn't contain instruction 'HEALTHCHECK'
COPY --from=builder /app/build /usr/share/nginx/html

# add permissions for a user
RUN chown -R 10000:10001 /app && chmod -R 775 /app/

Check notice

Code scanning / KICS

Multiple RUN, ADD, COPY, Instructions Listed Note

There are RUN instructions that could be grouped
RUN chown 10000:10001 /entrypoint.sh && chmod -R 775 /entrypoint.sh

# Install bash for env variables inject script
RUN apk update && apk add --no-cache bash

Check warning

Code scanning / KICS

Unpinned Package Version in Apk Add Warning

RUN instruction apk update && apk add --no-cache bash does not use package pinning form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants