-
Notifications
You must be signed in to change notification settings - Fork 5
Bugfixes (uuid regex, fix & refactor of policy validation) & warnings (multiple DTRs) #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dddenes
wants to merge
7
commits into
eclipse-tractusx:main
Choose a base branch
from
dddenes:bugfactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I solved your merge conflicts, I hope it is now ok. |
Contributor
|
tractusx-sdk-services/test-orchestrator/test_orchestrator/checks/request_catalog.py Lines 36 to 93 in 5b1a9cb
please make sure you add the warning in the get_catalog function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
validate_policy method in the orchestrator is now parametirezed with the data exchange & dtr policies. Method is refactored to remove the "if pyramid". Method is fixed, it now accepts odrl:and. Regression tests are added.
Closes this issue:
#36
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: