Simplification of UUri Data model #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 30, 2024 16:58
The following adds to #121 to simplify the datamodel for UUri object.
We also need to make the attributes optional, this is to allow us to do wildcard UUris to not set the UEntity and/or UResource information
sophokles73
reviewed
May 2, 2024
up-core-api/uprotocol/uri.proto
Outdated
| bytes id = 3; // Unique ID for the device, could be a VIN, SHA 128, or any other identifier | ||
| // *NOTE:* MAX length is 255 bytes | ||
| } | ||
| string name = 1; // Domain & device name as a string |
There was a problem hiding this comment.
FMPOV this would need to remain optional in order to consistently support matching any value across UUri's components.
Alternatively, we could think about defining explicit wildcard characters/values ...
There was a problem hiding this comment.
We discussed this and we are using explicit value definitions so there is no optional
up-core-api/uprotocol/uri.proto
Outdated
| optional uint32 version_minor = 4; // optional minor version of the uEntity | ||
| optional uint32 id = 1; // UEntity ID | ||
| optional uint32 version_major = 2; // optional major version of the uEntity | ||
| optional uint32 version_minor = 3; // optional minor version of the uEntity |
There was a problem hiding this comment.
I haven't seen any place yet where minor version is being used. Is this really needed?
There was a problem hiding this comment.
I have removed it. Minor is really only needed at the application layer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following adds to #121 to simplify the datamodel for UUri object.