fix: Configuration Cache Support #12
Open
+97
−231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wba2hi
force-pushed
the
configuration-cache-support
branch
from
5fa1db7 to
15a99fa
Compare
wba2hi
changed the title
lukasmittag
reviewed
Feb 19, 2025
| private fun addGeneratedPathToSourceSets( | ||
| project: Project, | ||
| sourceSetBasePath: String, | ||
| sourceSetBaseDir: File, |
There was a problem hiding this comment.
Could this be exchanged to type DirectoryProperty then it is type safe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue can be reproduced by executing
./gradlew clean build --configuration-cache. Depending on if the bugfix was applied, the build should be failing or succeed.Instead of using the project.file method to create a file (which automatically appends the absolute path to the project) we use the java.nio.File to create the corresponding file, while manually appending the absolute path to the file. The absolute path to the directory is read from the project and provided to the VssModelGenerator.
First build with failing configuration cache (pre-fix):
https://github.com/eclipse-velocitas/vehicle-app-java-sdk/actions/runs/13324918831/job/37216039585
Second build with successful configuration cache (post-fix):
https://github.com/eclipse-velocitas/vehicle-app-java-sdk/actions/runs/13325161423/job/37216749317