Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Compability for JDK 11 #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wba2hi
Copy link
Contributor

@wba2hi wba2hi commented Feb 14, 2025

This issue is a bit harder to reproduce locally. The following steps are necessary:

  1. Setup jenv for easy switching to different jdk versions
  2. Install openjdk17 and openjdk21
  3. Register openjdk17 and openjdk21 using jenv add ...
  4. open a terminal and switch to the project folder
  5. use jenv local 21 to use jdk21 for building the project
  6. execute ./gradlew clean build (the vss-processor-plugin here is now only supporting >= jdk 21 without the fix being applied; if build with jdk 17 it would be only supporting >= jdk 17)
  7. publish the artifact to mavenLocal (a few lines of code need to be adapted in code)
  8. change the samples to use the mavenLocal version and add mavenLocal to the plugin repositories
  9. execute jenv local 17 to switch to jdk17 for building the project
  10. execute ./gradlew clean build

Depending on if the fix was applied or not, an error message will be shown.

@wba2hi wba2hi force-pushed the jdk-11-compatibility branch 2 times, most recently from fc74761 to bd0a3a1 Compare February 14, 2025 13:05
@wba2hi wba2hi force-pushed the jdk-11-compatibility branch from bd0a3a1 to 4bedff2 Compare February 14, 2025 13:06
@wba2hi wba2hi changed the title chore: Build Project using different JDK Versions fix: Add Compability for JDK 11 Feb 14, 2025
@wba2hi wba2hi marked this pull request as ready for review February 14, 2025 13:27
Copy link

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants