Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Protobuf Files for App #4

Conversation

wba2hi
Copy link
Contributor

@wba2hi wba2hi commented Oct 8, 2024

The following PR makes sure, that the proto file which is put inside the app/src/main/proto folder correctly generates the corresponding services.

Needs to be merged after #5 because this PR adds new libraries, which need to be updated in the lockfile.

@wba2hi wba2hi force-pushed the build_protobuf_files_for_app branch from 710df01 to 33cc01f Compare October 8, 2024 07:56
@wba2hi wba2hi marked this pull request as draft October 8, 2024 07:57
wba2hi added 2 commits October 8, 2024 10:32
The following PR makes sure, that the proto file which is put inside
the app/src/main/proto folder correctly generates the corresponding
services.
@wba2hi wba2hi force-pushed the build_protobuf_files_for_app branch from 33cc01f to 28bf651 Compare October 8, 2024 08:33
@wba2hi wba2hi marked this pull request as ready for review October 8, 2024 08:37
Copy link
Contributor

@Chrylo Chrylo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:

  • Generating of the grpc files for the app with the door proto file

LGTM

Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BjoernAtBosch BjoernAtBosch merged commit 279fa9d into eclipse-velocitas:main Oct 9, 2024
2 checks passed
@BjoernAtBosch BjoernAtBosch deleted the build_protobuf_files_for_app branch October 9, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants