Fix interval type in STATE_REG_HOLD_OFF for overdue registrations #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishmac7
force-pushed
the
fix/registration-interval-type
branch
from
19a4d15 to
2dcff10
Compare
|
ashishmac7
force-pushed
the
fix/registration-interval-type
branch
from
2dcff10 to
bfb6bd4
Compare
|
LukasWoodtli
reviewed
Nov 6, 2025
ashishmac7
force-pushed
the
fix/registration-interval-type
branch
from
bfb6bd4 to
57412fd
Compare
Updated `interval` type from `time_t` to `int32_t` in registration.c to correctly handle negative differences when currentTime exceeds targetP->registration. This fixes a bug where unsigned `time_t` caused large positive intervals, delaying registrations. The change ensures compliance with LwM2M registration timing requirements. Signed-off-by: ashishmac7 <[email protected]>
ashishmac7
force-pushed
the
fix/registration-interval-type
branch
from
57412fd to
cc91e44
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
intervaltype fromtime_ttoint32_tin registration.c to correctly handle negative differences when currentTime exceeds targetP->registration. This fixes a bug where unsignedtime_tcaused large positive intervals, delaying registrations. The change ensures compliance with LwM2M registration timing requirements.