remove channel upon undeclaration of Subscriber and Queryable #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139
Note: Due to the timing difference in between issuing an UndeclareSubscriber from the front-end to the plugin, this change may cause the TS bindings to warn that a "Subscrption UUID not in map" Depending on the number of outstanding messages that still need to be flushed from the plugin before the undeclare is executed in the plugin.The state of a Subscriber lives on the Plugin, we have changed the way the TS client and the plugin handle undeclaring Subscribers.
The flow is as follows:
This should resolve the uncaught exception that occurs when another node floods this client with many samples, and allow a new subscriber to be declared on the same session.