Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap Interceptors with ArcSwap #1788

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

oteffahi
Copy link
Contributor

No description provided.

@oteffahi oteffahi self-assigned this Feb 20, 2025
Copy link

PR missing one of the required labels: {'enhancement', 'new feature', 'documentation', 'bug', 'internal', 'dependencies', 'breaking-change'}

@oteffahi oteffahi added the internal Changes not included in the changelog label Feb 20, 2025
@oteffahi oteffahi changed the title Wrap Interceptors with ArcSwap Wrap Interceptors with ArcSwap Feb 20, 2025
Copy link
Member

@sashacmc sashacmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please fix CI issues

@diogomatsubara
Copy link
Contributor

Tracked in Jira as [ZEN-483]

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 64.34109% with 46 lines in your changes missing coverage. Please review.

Project coverage is 70.86%. Comparing base (41ac4a7) to head (c8c9d1c).

Files with missing lines Patch % Lines
zenoh/src/net/routing/dispatcher/face.rs 24.32% 28 Missing ⚠️
zenoh/src/net/primitives/mux.rs 67.64% 11 Missing ⚠️
zenoh/src/net/routing/dispatcher/tables.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1788      +/-   ##
==========================================
- Coverage   71.02%   70.86%   -0.17%     
==========================================
  Files         360      360              
  Lines       65135    65205      +70     
==========================================
- Hits        46262    46205      -57     
- Misses      18873    19000     +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OlivierHecart OlivierHecart marked this pull request as draft March 10, 2025 11:31
@OlivierHecart
Copy link
Contributor

We need to take care of interceptor caches invalidation/regeneration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants