-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap Interceptors with ArcSwap
#1788
base: main
Are you sure you want to change the base?
Wrap Interceptors with ArcSwap
#1788
Conversation
PR missing one of the required labels: {'enhancement', 'new feature', 'documentation', 'bug', 'internal', 'dependencies', 'breaking-change'} |
ArcSwap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please fix CI issues
Tracked in Jira as [ZEN-483] |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1788 +/- ##
==========================================
- Coverage 71.02% 70.86% -0.17%
==========================================
Files 360 360
Lines 65135 65205 +70
==========================================
- Hits 46262 46205 -57
- Misses 18873 19000 +127 ☔ View full report in Codecov by Sentry. |
We need to take care of interceptor caches invalidation/regeneration. |
No description provided.