Add support for query/reply messages to Downsampling #1797
Merged
+273
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current implementation, rules within the same Downsampling config share the same state if configured on the same keyexpr. Having message types within the rules can lead users to configure different messages types within different rules with same keyexpr, which would produce the same result as having all message types within the same rule, i.e downsampling on the whole set of messages instead of doing so seperately for each type.
|
PR missing one of the required labels: {'dependencies', 'bug', 'new feature', 'internal', 'enhancement', 'breaking-change', 'documentation'} |
oteffahi
added
new feature
|
Clarification regarding my commit message for 963eb84: two rules on the same keyexpr would have the last rule in the list overwrite the previous one, which further supports why message types need to be moved out of the rules list. |
OlivierHecart
approved these changes
Mar 7, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1797 +/- ##
==========================================
+ Coverage 70.35% 70.90% +0.54%
==========================================
Files 359 360 +1
Lines 64617 65135 +518
==========================================
+ Hits 45460 46182 +722
+ Misses 19157 18953 -204 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds query/reply message filters to Downsampling interceptor. Query/reply message types are respectively named
"query"and"reply", with the addition of"push"which is the previously supported Publication message type.Downsampling config with different message types will apply its rules on all these message types as one flow of messages. Seperate Downsampling configurations with one type each will apply the rules per message type.
Also changes Downsampling config to accept a list of flows instead of a single one, to limit the need to duplicate a downsampling conf for query/reply messages which go in opposite flows.
Note that this PR breaks compatibility with previous format of Downsampling configuration.