The basic config #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TheZoker
commented
Dec 5, 2018
TheZoker
commented
- Adds lerna
- Adds basic tooling, vscode and theia package
- Adds basic tsconfig
add initial structure for the vs code extension Co-Authored-By: dzungbk156 <[email protected]> Co-Authored-By: mohschmid <[email protected]> Co-Authored-By: Florian Gareis <[email protected]>
Co-authored-by: dzungbk156 <[email protected]> Co-authored-by: mohschmid <[email protected]> Co-authored-by: roxhens <[email protected]>
edgarmueller
suggested changes
Dec 5, 2018
There was a problem hiding this comment.
Please add some instructions to the README on how to build the extensions (install dependencies, bootstrap etc.) and how to start them respectively. Ideally, I should be able to follow those instructions and start the VS Code extension/Theia plugin. Also add instructions for executing the tests.
edgarmueller
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.