Check use_aerosols with lw_aerosol_scattering
#33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check `use_aerosols` in addition to `lw_aerosol_scattering`. In principle, this does not change anything because, if `config%use_aerosols` is false then the single-scattering albedo of aerosols is set to 0 so the results of the two branches, `calc_no_scattering_transmittance_lw` + `calc_fluxes_no_scattering_lw`, and `calc_ref_trans_lw` + `adding_ica_lw`, is the same. In practice, the results are not exactly equal. This is surprising for the user, who expects that the setting of `config%do_lw_aerosol_scattering` can be disregarded if `config%use_aerosols` is false. Moreover, if `config%use_aerosols` is false, we want to go to the faster calculation, `calc_no_scattering_transmittance_lw` + `calc_fluxes_no_scattering_lw`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check
use_aerosolsin addition tolw_aerosol_scattering. In principle, this does not change anything because, ifconfig%use_aerosolsis false then the single-scattering albedo of aerosols is set to 0 so the results of the two branches,calc_no_scattering_transmittance_lw+calc_fluxes_no_scattering_lw, andcalc_ref_trans_lw+adding_ica_lw, is the same. In practice, the results are not exactly equal. This is surprising for the user, who expects that the setting ofconfig%do_lw_aerosol_scatteringcan be disregarded ifconfig%use_aerosolsis false. Moreover, ifconfig%use_aerosolsis false, we want to go to the faster calculation,calc_no_scattering_transmittance_lw+calc_fluxes_no_scattering_lw.