Remove _OVERLOAD layer #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhatfield
force-pushed
the
remove_overload_layer
branch
from
ae0b3c0 to
dfaa28f
Compare
samhatfield
force-pushed
the
remove_overload_layer
branch
from
dfaa28f to
7a9606b
Compare
lukasm91
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes one layer of routines in the Legendre transforms and permits us to call the cuBLAS/hipBLAS routines directly from LEINV/LEDIR via their Fortran bindings. The
*_OVERLOADlayer didn't do anything useful and was slowing down debugging of the OpenMP offload development.I won't mark this as a draft so that the CI suite is triggered, but please wait for my confirmation before merging.