Fix for building with single-precision NEMO #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdeconinck
force-pushed
the
naan-nemo-sp-fix
branch
from
80dd474 to
9b8ea07
Compare
|
Hi @awnawab I just noticed that with this PR we have two different preprocessor definitions now to control precision of ocean model: |
|
Hi @wdeconinck. Yes that makes a lot of sense, will do. Thanks! |
wdeconinck
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FIELD_API utility functions were not compatible with single-precision NEMO builds. This was exposed during the testing for CY49R2. This PR is a replication of the fix filed in ifs-source.