TAUT_Z0 convergence fix #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jrbidlot. Could you please give this PR a quick look? I have just cherry-picked your commit and updated the validation hashes. |
wdeconinck
approved these changes
Sep 4, 2024
awnawab
force-pushed
the
naan_wab_taut_z0_debug
branch
from
7c5d404 to
7d2179a
Compare
jrbidlot
approved these changes
Sep 11, 2024
awnawab
force-pushed
the
naan_wab_taut_z0_debug
branch
from
7d2179a to
8ff47e1
Compare
wdeconinck
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 49R1,
LLGCBZ0is set to.TRUE.and the point-wise convergence loop inTAUT_Z0is used. This was found to have a numerical instability that was triggered by the normal range of round-off error one can expect when running on GPU as compared to CPU.@jrbidlot fixed the numerical instability and confirmed the change was meteorologically neutral. Many many thanks again for resolving this so quickly 🙏 🙏
I am intentionally filing this PR to "develop-1.3", which is the technical development branch. "develop" is reserved for scientific developments, and this fix will make its way there eventually via a CY50R1 scientific contribution.
The PR also disables caching for the macos runners in the CI, which are intermittently fragile with caching enabled for some reason.