Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add continous integration with the last intel compilers #17

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

dareg
Copy link
Collaborator

@dareg dareg commented Jan 11, 2024

Downloads and install the last intel compilers from their official repository and run the field_api tests.

Note that it uses the new icx and ifx compilers instead of the old icc and ifort compilers.

@awnawab
Copy link
Collaborator

awnawab commented Jan 12, 2024

Happy new year @dareg and thanks for this much needed addition to the CI. We don't currently use ifx for ifs builds. Have you started using it? If you don't use it either, then perhaps it might be more useful to use ifort for the CI too. You can see an example here of how ifort rather than ifx can be installed: https://github.com/ecmwf-ifs/ecwam/blob/main/.github/tools/install-intel-oneapi.sh

@dareg
Copy link
Collaborator Author

dareg commented Jan 12, 2024

Hello,and happy new year too.

For the moment we don't use ifx either, we are still using ifort too.
But since November 2023 ifort is officially deprecated [1] and will be discontinued at the end of 2024, so I think it would good to check that our tests pass with ifx since I guess it would be the compiler installed on any new x86-64 supercomputer. That being said it's true that we should still test with ifort since this the one we use today.
I think both ifort and ifx are installed in the package intel-hpckit for now, so I propose that we run the tests with both.

[1] https://community.intel.com/t5/Blogs/Tech-Innovation/Tools/Deprecation-of-The-Intel-Fortran-Compiler-Classic-ifort/post/1541699

@awnawab
Copy link
Collaborator

awnawab commented Jan 12, 2024

Testing with both ifort and ifx makes a lot of sense to me too, I'd be happy with that!

@awnawab
Copy link
Collaborator

awnawab commented Jan 29, 2024

Hi @dareg. I have to file a fix for the FIELD_API build and CI setup. Do you think we could wrap up this PR soon, and then I'll rebase my changes on top of yours?

@FussyDuck
Copy link

FussyDuck commented Jan 30, 2024

CLA assistant check
All committers have signed the CLA.

@dareg
Copy link
Collaborator Author

dareg commented Jan 30, 2024

Done, @awnawab .
I've added the tests with the classic intel compilers into their own file. Will be easy to remove them when we won't need them any more.

Copy link
Collaborator

@awnawab awnawab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @dareg for adding both ifort and ifx CI tests 👍 Good to go from me!

@awnawab awnawab merged commit 48461a6 into ecmwf-ifs:main Jan 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants