Skip to content

Edits agreed by the CDM_OBS Governance group - 24th April 2025 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sjnoone
Copy link
Collaborator

@sjnoone sjnoone commented May 30, 2025

Hi,

Sorry for the delay.

Here are the edits agreed at the CDM_OBS Governance group call on the 24th April 2025.

Here is the link to boards page with all notes and agreed actions for reference.

https://board.net/p/C3S_311_CDM-OBS_Governance_call_24th_April

Can you please review the edits and merge them into the master if everything looks good?
Let me know if you have any questions or need clarification!

best
Simon

sjnoone added 6 commits April 23, 2025 10:56
edits units table entry 301 to be ppt rather than 0/000 agreed by CDM OBS governance April 2025
Added entries 20 and 21 to observations_fields table as agreed by the CDM_OBS governance in April 2025
eidts agreed by CDM_OBS Governance board May 2025
Edits agreed by the CDM-OBS Governance board May 2025
Edits agreed by the CDM-OBS Governance board May 2025
Edits agreed by the CDM-OBS Governance board May 2025
@FussyDuck
Copy link

FussyDuck commented May 30, 2025

CLA assistant check
All committers have signed the CLA.

@@ -46,7 +46,9 @@ units name abbreviation base_units
230 week NULL
231 year a NULL
300 per cent \% NULL
301 parts per thousand 0/00 NULL
301 parts per thousand ppt NULL
Copy link

@EddyCMWF EddyCMWF Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My experience is that ppt = parts per trillion. This is backed up by wikipedia. However, this is more a point for the governance board. permille (‰) is the more generally accepted units

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! and the symbol exists... we can make that correction.

@@ -46,7 +46,9 @@ units name abbreviation base_units
230 week NULL
231 year a NULL
300 per cent \% NULL
301 parts per thousand 0/00 NULL
301 parts per thousand ppt NULL
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
301 parts per thousand ppt NULL
301 parts per thousand \‰ NULL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants