-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(training,config)!: refactor node_weights #102
Draft
JPXKQX
wants to merge
44
commits into
7-pressure-level-scalings-only-applied-in-specific-circumstances
Choose a base branch
from
feature/move-extra-scalers
base: 7-pressure-level-scalings-only-applied-in-specific-circumstances
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix(training,config)!: refactor node_weights #102
JPXKQX
wants to merge
44
commits into
7-pressure-level-scalings-only-applied-in-specific-circumstances
from
feature/move-extra-scalers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umstances' into feature/move-extra-scalers
for more information, see https://pre-commit.ci
HCookie
reviewed
Jan 31, 2025
HCookie
reviewed
Jan 31, 2025
…/anemoi-core into feature/move-extra-scalers
for more information, see https://pre-commit.ci
…/anemoi-core into feature/move-extra-scalers
for more information, see https://pre-commit.ci
…/anemoi-core into feature/move-extra-scalers
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…/anemoi-core into feature/move-extra-scalers
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…/anemoi-core into feature/move-extra-scalers
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…/anemoi-core into feature/move-extra-scalers
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
HCookie
changed the title
refactor node_weights
fix(training,config)!: refactor node_weights
Feb 5, 2025
sahahner
reviewed
Feb 6, 2025
@@ -4,13 +4,15 @@ variable_groups: | |||
|
|||
# Several scalers can be added here. In order to be applied their names must be included in the loss. | |||
# scaler name must be included in `scalers` in the losses for this to be applied. | |||
# All scalers needs a `scale_dims` argument representing the dimension/s on which it is applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be updated as some scale_dims are now fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test:
to discuss: