Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(training,config)!: refactor node_weights #102

Draft
wants to merge 44 commits into
base: 7-pressure-level-scalings-only-applied-in-specific-circumstances
Choose a base branch
from

Conversation

JPXKQX
Copy link
Member

@JPXKQX JPXKQX commented Jan 31, 2025

  • Move node_weights to loss scalers
  • support unit-norm in node_weights
  • Fix Limited Area Mask
  • Fix Limited area mse (mse contributions)
  • Fix output mask over scalers
  • Fix post processors over scalers

Test:

  • Global
  • LAM (output_mask)
  • Stretched (limited_area_mask metrics)
  • combined loss

to discuss:

  • MSELoss vs MSE
  • scalers.builders, other options?
  • filenames (base.py,...)
  • validation metrics, list -> dict

@HCookie HCookie changed the title refactor node_weights fix(training,config)!: refactor node_weights Feb 5, 2025
@@ -4,13 +4,15 @@ variable_groups:

# Several scalers can be added here. In order to be applied their names must be included in the loss.
# scaler name must be included in `scalers` in the losses for this to be applied.
# All scalers needs a `scale_dims` argument representing the dimension/s on which it is applied
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated as some scale_dims are now fixed.

@icedoom888 icedoom888 linked an issue Feb 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Now In Progress
Development

Successfully merging this pull request may close these issues.

Limited Area Mask breaking Hierachical Graphs
3 participants