feat(model): fileGraphProvider - loading graphs from disk - #1245
Open
Sooph-knmi wants to merge 14 commits into
Open
feat(model): fileGraphProvider - loading graphs from disk#1245Sooph-knmi wants to merge 14 commits into
Sooph-knmi wants to merge 14 commits into
Conversation
…ces to non-existing graph attributes, pass graph_label and device to get_edges
… into feat/fileGraphProvider Merge branch 'main' into feat/fileGraphProvider
Sooph-knmi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supporting loading graphs from disk during training.
If the provided graph in
system.input.graphis aPath, the graphs are loaded from that folder with the new graph providerFileGraphProviderduring the model forward.Use cases:
No breaking changes.
What problem does this change solve?
Currently, the graph provider supports either static graphs or dynamically created graphs. When scaling up to a large amount of (possibly also large-sized) graphs, using static graphs can cause out of memory exceptions, and dynamically creating graphs causes an extreme slow-down in training.
What issue or task does this change relate to?
#1150
Additional notes
Right now, the model/traning initialization can still be slow because many graph attributes are loaded independently (see also the #1150 discussion). This might be something for a separate discussion.
Current implementation is only for
AnemoiModelEncProcDec. Can be extended to the other models if there is interest from the community.As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.
📚 Documentation preview 📚: https://anemoi-training--1245.org.readthedocs.build/en/1245/
📚 Documentation preview 📚: https://anemoi-graphs--1245.org.readthedocs.build/en/1245/
📚 Documentation preview 📚: https://anemoi-models--1245.org.readthedocs.build/en/1245/