fix: Add AttrType to safe globals for torch serialisation - #1308
Open
HCookie wants to merge 2 commits into
Open
Conversation
Addresses failing integration tests
Contributor
|
thanks for the quick fix! once these pass I'm happy to merge. |
Member
Author
|
This is failing with Without a change to pytorch, this is not fixable. |
PyTorch Geometric populates BaseStorage._cached_attr as a defaultdict(set) while building a graph. The strict weights_only=True unpickler used by load_graph_from_file cannot deserialize a defaultdict (it only allows SETITEMS on dict, OrderedDict and Counter), so a saved graph fails to load. Normalise the cache to a plain dict in GraphCreator.save() before torch.save to keep the save/load round-trip working without weakening serialization safety.
mc4117
pushed a commit
that referenced
this pull request
Aug 6, 2026
…emoi-graphs" (#1311) Reverts #1303 due to issues identified in the attempt of a hotfix in #1308 TLDR: Some LAM graphs come with a `_cache_attr` property which is a `defaultdict`, it is not needed, but is included by `torch_geometric` causing issues with `torch.load` > [!TIP] > Integration tests passed > https://github.com/ecmwf/anemoi-core/actions/runs/31090338148
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses failing integration tests caused by #1303 as seen in https://github.com/ecmwf/anemoi-core/actions/runs/31021131375/job/92360048174?pr=1295
Caution
Integration tests failed
https://github.com/ecmwf/anemoi-core/actions/runs/31024878202
New graph to replace old test graph
https://sites.ecmwf.int/ecm1947/files/Anemoi/lam-graph-rebuilt.pt
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.