Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(models): Copy Imputer #72

Merged
merged 16 commits into from
Feb 3, 2025
Merged

Conversation

icedoom888
Copy link
Contributor

@icedoom888 icedoom888 commented Jan 9, 2025

Add an imputer that copies missing information from another field.

When a value is missing at a certain Pressure Level it would be useful to copy the value of the Pressure Level above.
This technique ensures constant imputing in areas with missing Pressure Levels and will not cause a big delta in values with respect to vertical changes.

Solves #71

@icedoom888 icedoom888 self-assigned this Jan 9, 2025
@FussyDuck
Copy link

FussyDuck commented Jan 9, 2025

CLA assistant check
All committers have signed the CLA.

@icedoom888 icedoom888 changed the title Feature/copy imputer [Feature] Copy Imputer Jan 9, 2025
@HCookie
Copy link
Member

HCookie commented Jan 14, 2025

Can you please provide some more details on the description about where this imputer may be useful and some example code/config of it in action?

@icedoom888
Copy link
Contributor Author

Can you please provide some more details on the description about where this imputer may be useful and some example code/config of it in action?

@HCookie Done ✔️ Is it clearer now?

@icedoom888 icedoom888 requested a review from HCookie January 15, 2025 14:14
@HCookie HCookie removed the request for review from JesperDramsch January 16, 2025 16:14
HCookie
HCookie previously approved these changes Jan 27, 2025
Copy link
Member

@HCookie HCookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments,
As this is only a new class, I assume you have tested the functionality, and it behaves as expected.

@icedoom888 icedoom888 changed the title [Feature] Copy Imputer feat: Copy Imputer Jan 29, 2025
@icedoom888 icedoom888 requested a review from HCookie January 29, 2025 13:17
@icedoom888
Copy link
Contributor Author

Yes this is tested and working!

@icedoom888 icedoom888 changed the title feat: Copy Imputer feat(models): Copy Imputer Jan 29, 2025
@icedoom888 icedoom888 added the enhancement New feature or request label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request models
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants