better error message

ecmwf · Nov 24, 2024 · 26a32a1 · 26a32a1
1 parent c3b6e0c
commit 26a32a1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/anemoi/datasets/data/dataset.py b/src/anemoi/datasets/data/dataset.py
@@ -245,7 +245,8 @@ def _drop_to_columns(self, vars):
         if not isinstance(vars, (list, tuple, set)):
             vars = [vars]
 
-        assert set(vars) <= set(self.name_to_index)
+        if not set(vars) <= set(self.name_to_index):
+            raise ValueError(f"drop: unknown variables: {set(vars) - set(self.name_to_index)}")
 
         return sorted([v for k, v in self.name_to_index.items() if k not in vars])
 

diff --git a/src/anemoi/datasets/data/join.py b/src/anemoi/datasets/data/join.py
@@ -124,7 +124,14 @@ def variables_metadata(self):
                 if v in md:
                     result[v] = md[v]
 
-        assert len(result) == len(variables), (result, variables)
+        if len(result) != len(variables):
+            LOG.error("Some variables are missing metadata.")
+            for v in variables:
+                if v not in result:
+                    LOG.error("Missing metadata for %r.", v)
+
+            raise ValueError("Some variables are missing metadata.")
+
         return result
 
     @cached_property