Skip to content

Commit

Permalink
Fix formatting
Browse files Browse the repository at this point in the history
  • Loading branch information
dsarmany committed Jan 21, 2025
1 parent da7b567 commit 55e5921
Show file tree
Hide file tree
Showing 56 changed files with 557 additions and 603 deletions.
2 changes: 1 addition & 1 deletion src/multio/action/encode/GribEncoder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@

#include "multio/LibMultio.h"
#include "multio/util/DateTime.h"
#include "multio/util/Environment.h"
#include "multio/util/Metadata.h"
#include "multio/util/Substitution.h"
#include "multio/util/Environment.h"

#include "multio/util/PrecisionTag.h"

Expand Down
2 changes: 1 addition & 1 deletion src/multio/action/encode/GridDownloader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
#include "eckit/mpi/Comm.h"

#include "multio/message/Glossary.h"
#include "multio/util/Substitution.h"
#include "multio/util/Environment.h"
#include "multio/util/Substitution.h"

namespace {
const std::unordered_map<std::string, int> latParamIds{
Expand Down
4 changes: 2 additions & 2 deletions src/multio/action/scale/Mapping.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
#include <cstdlib>
#include <string>

#include "MetadataUtils.h"
#include "multio/LibMultio.h"
#include "multio/message/Glossary.h"
#include "multio/util/Substitution.h"
#include "MetadataUtils.h"


namespace multio::action {
Expand Down Expand Up @@ -35,7 +35,7 @@ void ScaleMapping::applyMapping(message::Metadata& md) const {

auto it = scaleMap_.find(cparam);
if (it != scaleMap_.end()) {
md.set(glossary().paramId, std::stoll(it->second));
md.set(glossary().paramId, std::stoll(it->second));
md.set(glossary().param, it->second.c_str());
}
}
Expand Down
5 changes: 3 additions & 2 deletions src/multio/action/scale/MetadataUtils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ std::string extractParam(const multio::message::Metadata& md) {
std::string cparam{};
if (auto param = md.getOpt<std::string>(glossary().param); param) {
cparam = *param;
} else if (auto paramId = md.getOpt<std::int64_t>(glossary().paramId); paramId) {
}
else if (auto paramId = md.getOpt<std::int64_t>(glossary().paramId); paramId) {
cparam = std::to_string(*paramId);
}
else {
Expand All @@ -23,4 +24,4 @@ std::string extractParam(const multio::message::Metadata& md) {

return cparam;
}
}
} // namespace multio::action
3 changes: 1 addition & 2 deletions src/multio/action/scale/MetadataUtils.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,5 @@
#include "multio/message/Metadata.h"

namespace multio::action {
std::string extractParam(const multio::message::Metadata& md);

std::string extractParam(const multio::message::Metadata& md);
}
8 changes: 4 additions & 4 deletions src/multio/action/scale/Scale.cc
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
#include "multio/util/PrecisionTag.h"

#include "multio/action/scale/Mapping.h"
#include "multio/action/scale/Scaling.h"
#include "multio/action/scale/MetadataUtils.h"
#include "multio/action/scale/Scaling.h"


namespace multio::action {
Expand Down Expand Up @@ -57,12 +57,12 @@ void Scale::executeImpl(message::Message msg) {
executeNext(std::move(msg));
return;
}
//Scale the message
// Scale the message
util::dispatchPrecisionTag(msg.precision(), [&](auto pt) {
using Precision = typename decltype(pt)::type;
ScaleMessage<Precision>(msg); // Modify msg in place
ScaleMessage<Precision>(msg); // Modify msg in place
});
//pass on the modified message
// pass on the modified message
executeNext(std::move(msg));
return;
}
Expand Down
2 changes: 1 addition & 1 deletion src/multio/action/scale/Scale.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#pragma once

#include "multio/action/ChainedAction.h"
#include "multio/config/ComponentConfiguration.h"
#include "multio/config/ComponentConfiguration.h"

#include "multio/action/scale/Mapping.h"
#include "multio/action/scale/Scaling.h"
Expand Down
2 changes: 1 addition & 1 deletion src/multio/action/scale/Scaling.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
#include <string>

#include "eckit/config/LocalConfiguration.h"
#include "multio/action/scale/MetadataUtils.h"
#include "multio/config/ComponentConfiguration.h"
#include "multio/message/Glossary.h"
#include "multio/message/Message.h"
#include "multio/action/scale/MetadataUtils.h"

namespace multio::action {

Expand Down
3 changes: 2 additions & 1 deletion src/multio/action/select/Select.cc
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ namespace multio::action {

//--------------------------------------------------------------------------------------------------

Select::Select(const ComponentConfiguration& compConf) : ChainedAction{compConf}, selectors_{MatchReduce::construct( compConf.parsedConfig())} {}
Select::Select(const ComponentConfiguration& compConf) :
ChainedAction{compConf}, selectors_{MatchReduce::construct(compConf.parsedConfig())} {}

void Select::executeImpl(Message msg) {
if (matches(msg)) {
Expand Down
30 changes: 16 additions & 14 deletions src/multio/action/statistics/OperationWindow.cc
Original file line number Diff line number Diff line change
Expand Up @@ -57,16 +57,16 @@ eckit::DateTime yyyymmdd_hhmmss2DateTime(uint64_t yyyymmdd, uint64_t hhmmss) {
} // namespace


OperationWindow make_window( const std::unique_ptr<PeriodUpdater>& periodUpdater, const StatisticsConfiguration& cfg) {
OperationWindow make_window(const std::unique_ptr<PeriodUpdater>& periodUpdater, const StatisticsConfiguration& cfg) {
eckit::DateTime epochPoint{cfg.epoch()};
eckit::DateTime startPoint{periodUpdater->computeWinStartTime(cfg.winStart())};
eckit::DateTime creationPoint{periodUpdater->computeWinCreationTime(cfg.winStart())};
eckit::DateTime endPoint{periodUpdater->computeWinEndTime(startPoint)};
long windowType = 0;
if ( cfg.options().windowType() == "forward-offset" ){
if (cfg.options().windowType() == "forward-offset") {
windowType = 0;
}
else if ( cfg.options().windowType() == "backward-offset" ) {
else if (cfg.options().windowType() == "backward-offset") {
windowType = 1;
}
else {
Expand All @@ -77,8 +77,8 @@ OperationWindow make_window( const std::unique_ptr<PeriodUpdater>& periodUpdater
return OperationWindow{epochPoint, startPoint, creationPoint, endPoint, cfg.timeStep(), windowType};
};

OperationWindow load_window( std::shared_ptr<StatisticsIO>& IOmanager, const StatisticsOptions& opt ) {
IOmanager->pushDir( "operationWindow" );
OperationWindow load_window(std::shared_ptr<StatisticsIO>& IOmanager, const StatisticsOptions& opt) {
IOmanager->pushDir("operationWindow");
// std::ostringstream logos;
// logos << " - Loading operationWindow from: " << IOmanager->getCurrentDir() << std::endl;
// LOG_DEBUG_LIB(LibMultio) << logos.str() << std::endl;
Expand Down Expand Up @@ -125,15 +125,15 @@ long OperationWindow::count() const {
void OperationWindow::dump(std::shared_ptr<StatisticsIO>& IOmanager, const StatisticsOptions& opt) const {
IOBuffer restartState{IOmanager->getBuffer(restartSize())};
restartState.zero();
serialize(restartState, IOmanager->getCurrentDir() + "/operationWindow_dump.txt", opt );
IOmanager->write("operationWindow", static_cast<size_t>(16), restartSize() );
serialize(restartState, IOmanager->getCurrentDir() + "/operationWindow_dump.txt", opt);
IOmanager->write("operationWindow", static_cast<size_t>(16), restartSize());
IOmanager->flush();
return;
}

void OperationWindow::load(std::shared_ptr<StatisticsIO>& IOmanager, const StatisticsOptions& opt) {
IOBuffer restartState{IOmanager->getBuffer(restartSize())};
IOmanager->read( "operationWindow", restartSize() );
IOmanager->read("operationWindow", restartSize());
deserialize(restartState, IOmanager->getCurrentDir() + "/operationWindow_load.txt", opt);
restartState.zero();
return;
Expand Down Expand Up @@ -163,9 +163,11 @@ void OperationWindow::updateWindow(const eckit::DateTime& startPoint, const ecki
std::string OperationWindow::windowType() const {
if (type_ == 0) {
return std::string{"forward-offset"};
} else if (type_ == 1) {
}
else if (type_ == 1) {
return std::string{"backward-offset"};
} else {
}
else {
std::ostringstream os;
os << *this << " Unknown window type " << std::endl;
throw eckit::SeriousBug(os.str(), Here());
Expand All @@ -175,10 +177,10 @@ std::string OperationWindow::windowType() const {

bool OperationWindow::isWithin(const eckit::DateTime& dt) const {
bool ret;
if ( type_ == 0 ) {
if (type_ == 0) {
ret = gtLowerBound(dt, false) && leUpperBound(dt, false);
}
else if ( type_ == 1 ) {
else if (type_ == 1) {
ret = geLowerBound(dt, false) && ltUpperBound(dt, false);
}
else {
Expand Down Expand Up @@ -434,7 +436,7 @@ long OperationWindow::lastFlushInSteps() const {

void OperationWindow::serialize(IOBuffer& currState, const std::string& fname, const StatisticsOptions& opt) const {

if ( opt.debugRestart() ) {
if (opt.debugRestart()) {
std::ofstream outFile(fname);
outFile << "epochPoint_ :: " << epochPoint_ << std::endl;
outFile << "startPoint_ :: " << startPoint_ << std::endl;
Expand Down Expand Up @@ -493,7 +495,7 @@ void OperationWindow::deserialize(const IOBuffer& currState, const std::string&
count_ = static_cast<long>(currState[15]);
type_ = static_cast<long>(currState[16]);

if ( opt.debugRestart() ) {
if (opt.debugRestart()) {
std::ofstream outFile(fname);
outFile << "epochPoint_ :: " << epochPoint_ << std::endl;
outFile << "startPoint_ :: " << startPoint_ << std::endl;
Expand Down
15 changes: 7 additions & 8 deletions src/multio/action/statistics/OperationWindow.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
#include "eckit/types/DateTime.h"


#include "multio/action/statistics/cfg/StatisticsOptions.h"
#include "StatisticsIO.h"
#include "multio/action/statistics/cfg/StatisticsConfiguration.h"
#include "multio/action/statistics/cfg/StatisticsOptions.h"
#include "multio/action/statistics/period-updaters/PeriodUpdater.h"
#include "StatisticsIO.h"
#include "multio/message/Message.h"
#include "multio/util/DateTime.h"

Expand All @@ -20,16 +20,16 @@ class OperationWindow {
OperationWindow(std::shared_ptr<StatisticsIO>& IOmanager, const StatisticsOptions& opt);

OperationWindow(const eckit::DateTime& epochPoint, const eckit::DateTime& startPoint,
const eckit::DateTime& creationPoint, const eckit::DateTime& endPoint,
long timeStepInSeconds, long windowType);
const eckit::DateTime& creationPoint, const eckit::DateTime& endPoint, long timeStepInSeconds,
long windowType);

long count() const;

void updateData(const eckit::DateTime& currentPoint);
void updateWindow(const eckit::DateTime& startPoint, const eckit::DateTime& endPoint);

void dump(std::shared_ptr<StatisticsIO>& IOmanager, const StatisticsOptions& opt) const;
void load(std::shared_ptr<StatisticsIO>& IOmanager, const StatisticsOptions& opt );
void load(std::shared_ptr<StatisticsIO>& IOmanager, const StatisticsOptions& opt);

std::string windowType() const;
bool isWithin(const eckit::DateTime& dt) const;
Expand Down Expand Up @@ -123,8 +123,7 @@ class OperationWindow {
friend std::ostream& operator<<(std::ostream& os, const OperationWindow& a);
};

OperationWindow make_window( const std::unique_ptr<PeriodUpdater>& periodUpdater, const StatisticsConfiguration& cfg);
OperationWindow load_window( std::shared_ptr<StatisticsIO>& IOmanager, const StatisticsOptions& opt );
OperationWindow make_window(const std::unique_ptr<PeriodUpdater>& periodUpdater, const StatisticsConfiguration& cfg);
OperationWindow load_window(std::shared_ptr<StatisticsIO>& IOmanager, const StatisticsOptions& opt);

} // namespace multio::action

30 changes: 13 additions & 17 deletions src/multio/action/statistics/Operations.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,23 @@

namespace multio::action {

void parse_file_name( const std::string& file, std::string& opname, std::string& precision ){
void parse_file_name(const std::string& file, std::string& opname, std::string& precision) {
static const std::regex operation_grammar("([a-z]+)_([a-z]+)");
std::smatch match;
if (std::regex_match(file, match, operation_grammar)) {
precision = match[2].str();
opname = match[1].str();
opname = match[1].str();
}
else {
throw eckit::SeriousBug("Wrong grammar in operation definition : " + file, Here());
}
};


std::vector<std::unique_ptr<Operation>> make_operations(const std::vector<std::string>& opNames,
message::Message msg,
std::vector<std::unique_ptr<Operation>> make_operations(const std::vector<std::string>& opNames, message::Message msg,
std::shared_ptr<StatisticsIO>& IOmanager,
const OperationWindow& win,
const StatisticsConfiguration& cfg ) {
const StatisticsConfiguration& cfg) {

return multio::util::dispatchPrecisionTag(msg.precision(), [&](auto pt) {
using Precision = typename decltype(pt)::type;
Expand All @@ -48,28 +47,25 @@ std::vector<std::unique_ptr<Operation>> make_operations(const std::vector<std::s
};



std::vector<std::unique_ptr<Operation>> load_operations(std::shared_ptr<StatisticsIO>& IOmanager,
const OperationWindow& win,
const StatisticsOptions& opt) {
const OperationWindow& win, const StatisticsOptions& opt) {
std::vector<std::unique_ptr<Operation>> stats;
IOmanager->pushDir( "operations" );
IOmanager->pushDir("operations");
// std::ostringstream logos;
// logos << " - Loading operations from: " << IOmanager->getCurrentDir() << std::endl;
// std::cout << logos.str() << std::endl;
std::vector<eckit::PathName> files = IOmanager->getFiles();
for (const auto& file : files) {
std::string opname;
std::string precision;
parse_file_name( file.baseName(false).asString(), opname, precision );
parse_file_name(file.baseName(false).asString(), opname, precision);
// std::ostringstream logos;
// logos << " - Loading " << opname << " operation from: " << file.baseName(false).asString() << std::endl;
// std::cout << logos.str() << std::endl;
stats.push_back(
multio::util::dispatchPrecisionTag(precision, [&](auto pt) {
using Precision = typename decltype(pt)::type;
return load_operation<Precision>(opname, IOmanager, win,opt );
}) );
// logos << " - Loading " << opname << " operation from: " << file.baseName(false).asString() <<
// std::endl; std::cout << logos.str() << std::endl;
stats.push_back(multio::util::dispatchPrecisionTag(precision, [&](auto pt) {
using Precision = typename decltype(pt)::type;
return load_operation<Precision>(opname, IOmanager, win, opt);
}));
}
IOmanager->popDir();
return stats;
Expand Down
13 changes: 6 additions & 7 deletions src/multio/action/statistics/Operations.h
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ std::unique_ptr<Operation> make_operation(const std::string& opname, long sz, st


template <typename Precision>
std::unique_ptr<Operation> load_operation( const std::string& opname, std::shared_ptr<StatisticsIO>& IOmanager,
const OperationWindow& win, const StatisticsOptions& opt) {
std::unique_ptr<Operation> load_operation(const std::string& opname, std::shared_ptr<StatisticsIO>& IOmanager,
const OperationWindow& win, const StatisticsOptions& opt) {

std::unique_ptr<Operation> ret;
bool found = false;
Expand Down Expand Up @@ -105,14 +105,13 @@ std::unique_ptr<Operation> load_operation( const std::string& opname, std::share
ret = std::make_unique<FixedWindowFluxAverage<Precision>>(opname, win, IOmanager, opt);
}

if ( !found ){
std::ostringstream os;
os << "Invalid opname in statistics operation :: " << opname << std::endl;
throw eckit::UserError(os.str(), Here());
if (!found) {
std::ostringstream os;
os << "Invalid opname in statistics operation :: " << opname << std::endl;
throw eckit::UserError(os.str(), Here());
}

return ret;

}

std::vector<std::unique_ptr<Operation>> make_operations(const std::vector<std::string>& opNames, message::Message msg,
Expand Down
Loading

0 comments on commit 55e5921

Please sign in to comment.